fix: require fix in suggestion objects#298
Merged
fasttime merged 1 commit intoeslint:mainfrom Oct 20, 2025
Merged
Conversation
1 task
DMartens
approved these changes
Oct 17, 2025
DMartens
left a comment
There was a problem hiding this comment.
Changes LGTM, thanks for spotting this.
Leaving this open for 2 days if someone else wants to take a look.
Merged
9 tasks
lumirlumir
added a commit
that referenced
this pull request
Oct 30, 2025
This reverts commit 02bac50.
9 tasks
overlookmotel
pushed a commit
to oxc-project/oxc
that referenced
this pull request
Jan 22, 2026
…#18396) Hi, this is my first contribution here, so I'm not sure whether opening a PR directly is appropriate. If anything is wrong, please let me know! --- In this PR, I've corrected the `DiagnosticData` type to `Record<string, string | number | boolean | bigint | null | undefined>;` In ESLint v9.39.2 (which uses `@eslint/core@0.17.0`), this type was widened to `Record<string, unknown>`. Refs: - https://github.com/eslint/rewrite/releases/tag/core-v0.17.0 - eslint/rewrite#298 However, in the ESLint v10.0.0 pre-release (which uses `@eslint/core@1.0.1`), this type have been narrowed to `Record<string, string | number | boolean | bigint | null | undefined>;`. Refs: - https://github.com/eslint/rewrite/releases/tag/core-v1.0.1 - eslint/rewrite#327 If the type's intention is to ensure maximum compatibility with any ESLint version, then `Record<string, string | number | boolean | bigint | null | undefined>` seems the most appropriate choice here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
This PR updates TypeScript types for suggestion objects so that the
fixproperty is required.This prevents creating suggestions without a fix, which would otherwise cause the runtime error:
It also broadens the type of
datafromRecord<string, string>→Record<string, unknown>because ESLint message interpolation can accept any value that can be stringified.What changes did you make? (Give an overview)
fixrequired inSuggestedEditBase.datatype toRecord<string, unknown>for compatibility with ESLint message interpolation.datato ensure various types are allowed.@ts-expect-errorin test wherefix: nullis used.Related Issues
Is there anything you'd like reviewers to focus on?