fix(dashboard): show the plan-checkpoint modal in the web UI (#832)#840
Merged
Conversation
…he modal (#832) The agent emits a `plan_checkpoint` pause request after each completed step. The TUI handled it by setting `pendingCheckpoint` and rendering the local Continue / Revise / Stop card, but the dashboard side was silent — the broadcast effect that mirrors plan / edit-review / revision modals over SSE had no checkpoint case. From the user's perspective the web UI just froze: the model was waiting on a button the page never rendered. Also adds the missing branch to `getActiveModal` so a dashboard that connects mid-checkpoint replays the modal instead of starting blank. The dashboard modal component (`CheckpointModal`), the resolve route (`/api/modal/resolve` with `kind: "checkpoint"`), and the App-side `resolveCheckpointConfirm` resolver were already in place — only the broadcast was missing. Closes #832
ChasLui
pushed a commit
to ChasLui/DeepSeek-Reasonix
that referenced
this pull request
May 23, 2026
…he modal (esengine#832) (esengine#840) The agent emits a `plan_checkpoint` pause request after each completed step. The TUI handled it by setting `pendingCheckpoint` and rendering the local Continue / Revise / Stop card, but the dashboard side was silent — the broadcast effect that mirrors plan / edit-review / revision modals over SSE had no checkpoint case. From the user's perspective the web UI just froze: the model was waiting on a button the page never rendered. Also adds the missing branch to `getActiveModal` so a dashboard that connects mid-checkpoint replays the modal instead of starting blank. The dashboard modal component (`CheckpointModal`), the resolve route (`/api/modal/resolve` with `kind: "checkpoint"`), and the App-side `resolveCheckpointConfirm` resolver were already in place — only the broadcast was missing. Closes esengine#832
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useEffectthat broadcastsmodal-upwhenpendingCheckpointchanges, and the missing branch ingetActiveModalso a dashboard that connects mid-checkpoint replays the modal instead of starting blank.CheckpointModalin the dashboard SPA, the/api/modal/resolveroute acceptingkind: "checkpoint", and theresolveCheckpointConfirmresolver on App.tsx. The TUI was rendering the prompt because it readspendingCheckpointstate directly; only the bridge to the web UI was missing.Test plan
npx vitest run tests/— 2857 passed / 3 skipped, 189 files cleantsc --noEmitclean (typed against the existingActiveModal["checkpoint"]variant)Closes #832