feat(composer): Ctrl+P / Ctrl+N navigate input-prefix pickers when open#662
Merged
Conversation
When any of the three input-prefix pickers is active — slash command (`/`), @-mention file picker, or slash-argument enum picker — Ctrl+P and Ctrl+N now move the highlighted row up/down, matching what ↑/↓ already do. Falls through to prompt-history recall when no picker is open, so single-key bash parity is preserved. Previously Ctrl+P/N always handed off to history recall regardless of picker state — reported as keymap inconsistency in issue #647 (the external-editor change is its own PR; this is the keymap half). Implementation: `App.tsx` wraps `recallPrev` / `recallNext` from `useInputRecall` in two memoized callbacks that consult atState / slashArgMatches / slashMatches first (priority matching the existing ↑/↓ handler's order), and routes them into `PromptInput` instead of the raw recall functions. Closes #647
2e657c6 to
1be8cac
Compare
esengine
added a commit
that referenced
this pull request
May 11, 2026
Hotfix for 0.39.0 install failure: the `postinstall: patch-package` hook + missing `patch-package` runtime dep + missing `patches/` in the files array meant fresh `npm install` / `npx reasonix@latest` runs crashed before the binary was usable. 0.39.0 has been deprecated on npm and `latest` rolled back to 0.38.0. Removes the patch-package machinery entirely — it can't work for a published library since npm hoists `ink` out of reasonix's own `node_modules`. The ink alt-screen render fix (#639) will return via a forked ink + `npm:` alias (#663) in a later release. Piggybacks three PRs that landed since 0.39.0: - #632 fix(web): actionable web_search / web_fetch errors - #661 feat(composer): Ctrl+X opens \$EDITOR - #662 feat(composer): Ctrl+P / Ctrl+N picker navigation
ChasLui
pushed a commit
to ChasLui/DeepSeek-Reasonix
that referenced
this pull request
May 23, 2026
…en (esengine#662) When any of the three input-prefix pickers is active — slash command (`/`), @-mention file picker, or slash-argument enum picker — Ctrl+P and Ctrl+N now move the highlighted row up/down, matching what ↑/↓ already do. Falls through to prompt-history recall when no picker is open, so single-key bash parity is preserved. Previously Ctrl+P/N always handed off to history recall regardless of picker state — reported as keymap inconsistency in issue esengine#647 (the external-editor change is its own PR; this is the keymap half). Implementation: `App.tsx` wraps `recallPrev` / `recallNext` from `useInputRecall` in two memoized callbacks that consult atState / slashArgMatches / slashMatches first (priority matching the existing ↑/↓ handler's order), and routes them into `PromptInput` instead of the raw recall functions. Closes esengine#647
ChasLui
pushed a commit
to ChasLui/DeepSeek-Reasonix
that referenced
this pull request
May 23, 2026
Hotfix for 0.39.0 install failure: the `postinstall: patch-package` hook + missing `patch-package` runtime dep + missing `patches/` in the files array meant fresh `npm install` / `npx reasonix@latest` runs crashed before the binary was usable. 0.39.0 has been deprecated on npm and `latest` rolled back to 0.38.0. Removes the patch-package machinery entirely — it can't work for a published library since npm hoists `ink` out of reasonix's own `node_modules`. The ink alt-screen render fix (esengine#639) will return via a forked ink + `npm:` alias (esengine#663) in a later release. Piggybacks three PRs that landed since 0.39.0: - esengine#632 fix(web): actionable web_search / web_fetch errors - esengine#661 feat(composer): Ctrl+X opens \$EDITOR - esengine#662 feat(composer): Ctrl+P / Ctrl+N picker navigation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When any of the three input-prefix pickers is active — slash command (
/), @-mention file picker, or slash-argument enum picker —Ctrl+PandCtrl+Nnow move the highlighted row up/down, matching what ↑/↓ already do. Falls through to prompt-history recall when no picker is open, so single-key bash parity is preserved.Previously
Ctrl+P/Ctrl+Nalways handed off to history recall regardless of picker state — reported as keymap inconsistency in #647 (the external-editor change is #661; this is the keymap half).Closes #647
Test plan