Skip to content

Feat/theme picker#543

Closed
J3y0r wants to merge 4 commits into
esengine:mainfrom
J3y0r:feat/theme-picker
Closed

Feat/theme picker#543
J3y0r wants to merge 4 commits into
esengine:mainfrom
J3y0r:feat/theme-picker

Conversation

@J3y0r

@J3y0r J3y0r commented May 9, 2026

Copy link
Copy Markdown

What

Added a theme picker selection page with only /theme commands

Why

As a supplement to the theme system

How to verify

run /theme

Checklist

  • [ ✓] npm run verify passes locally (lint + typecheck + tests + comment-policy gate)
  • [ ✓] No Co-Authored-By: Claude trailer in commits
  • [ ✓] Comments follow CONTRIBUTING.md (no module-essay headers, no incident history)
  • [ ✓] No edits to CHANGELOG.md — release notes are maintainer-written at release time

@esengine

esengine commented May 9, 2026

Copy link
Copy Markdown
Owner

Both pending items from #452's review landed in one PR — high-contrast brings the first-party set to three (matching #449's third theme), and bare /theme opening a picker is the right shape since it mirrors /model. Lifting themeName into App so a save triggers a live re-render (instead of waiting for next launch) is the right call too.

The picker's current preference / active now tags subsume what formatThemeStatus used to print — losing the verbose status line is a net UX win, and the test asserting both tags is a nice touch.

One stale-merge note: package-lock.json shows 0.30.5 → 0.33.2, but main is already on 0.36.0. Not blocking — I'll regenerate post-merge.

Will merge as-is.

@esengine

esengine commented May 9, 2026

Copy link
Copy Markdown
Owner

Actually one ask before I merge — it's CONFLICTING against main right now (package-lock.json: your branch is on 0.33.2, main shipped 0.36.0). Can you rebase on main and regenerate the lockfile (npm install after the rebase)? Once it's green I'll land it.

@J3y0r J3y0r force-pushed the feat/theme-picker branch from d9b6f1f to 84df6fe Compare May 10, 2026 00:56
@J3y0r

J3y0r commented May 10, 2026

Copy link
Copy Markdown
Author

Actually one ask before I merge — it's CONFLICTING against main right now (package-lock.json: your branch is on 0.33.2, main shipped 0.36.0). Can you rebase on main and regenerate the lockfile (npm install after the rebase)? Once it's green I'll land it.

finished

@esengine

Copy link
Copy Markdown
Owner

Thanks for the picker! I rebased it onto current main (which had moved on with #549 / #552 / #555 / #560 / #566 since you opened this) and patched the count test that needed a bump from 12 → 11 advanced commands once /theme moved out of the advanced group — easy to miss. The rebased version is at #567 and goes out in the next release. Closing this in favour of that one — your authorship is preserved on the originating commits.

@esengine esengine closed this May 10, 2026
esengine added a commit that referenced this pull request May 10, 2026
Surfaces a SingleSelect modal for the terminal theme preference. Bare
\`/theme\` opens the picker; \`/theme <name>\` keeps its existing
"persist and report" behaviour. Moves the slash entry from the
advanced group to setup and adds high-contrast to the arg completer.

Adapted from J3y0r's PR — repointed onto current main (which had
since reformatted App.tsx around the InflightProvider wrap from
#566) and the count test in tests/ui-slash-suggestions.test.tsx
updated from 12 → 11 advanced commands now that /theme has moved
out of the advanced bucket.

Thanks @J3y0r for the contribution.
@esengine esengine mentioned this pull request May 10, 2026
5 tasks
ChasLui pushed a commit to ChasLui/DeepSeek-Reasonix that referenced this pull request May 23, 2026
Surfaces a SingleSelect modal for the terminal theme preference. Bare
\`/theme\` opens the picker; \`/theme <name>\` keeps its existing
"persist and report" behaviour. Moves the slash entry from the
advanced group to setup and adds high-contrast to the arg completer.

Adapted from J3y0r's PR — repointed onto current main (which had
since reformatted App.tsx around the InflightProvider wrap from
esengine#566) and the count test in tests/ui-slash-suggestions.test.tsx
updated from 12 → 11 advanced commands now that /theme has moved
out of the advanced bucket.

Thanks @J3y0r for the contribution.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants