i18n(app): localize ~26 user-facing strings in App.tsx#447
Merged
Conversation
Two patterns rolled into one PR: 1. Wire seven existing ui.* keys that had been defined in EN.ts / zh-CN.ts but never actually called: ephemeralSession, resumedSession, newSession, restoredEdits, resumedPlan, tipEditBindings, dashboardAutoStartFailed. The keys had drifted into dead code — same pattern that bit the loop.* namespace before #445. 2. New app.* namespace (~24 keys) covering every other hardcoded user-facing string in App.tsx: - walk cancel (with / without remaining count) - edit-mode cycle (review / auto / yolo) - reject / auto-approve / flip-to-auto messages - dashboard stopped, /restore code-mode-only - hash-memory note (with translated scope + verb) - bash-mode + memory-write failures - hook headers (UserPromptSubmit, Stop) - @mentions / @url expansion + failure - shell confirm (deny / always-allow / running / starting) - checkpoint saved - plan continue / stop / revise zh-CN translations for all 31 new keys. Test plan: full suite 2301 pass, tsc + biome clean.
This was referenced May 8, 2026
ChasLui
pushed a commit
to ChasLui/DeepSeek-Reasonix
that referenced
this pull request
May 23, 2026
Two patterns rolled into one PR: 1. Wire seven existing ui.* keys that had been defined in EN.ts / zh-CN.ts but never actually called: ephemeralSession, resumedSession, newSession, restoredEdits, resumedPlan, tipEditBindings, dashboardAutoStartFailed. The keys had drifted into dead code — same pattern that bit the loop.* namespace before esengine#445. 2. New app.* namespace (~24 keys) covering every other hardcoded user-facing string in App.tsx: - walk cancel (with / without remaining count) - edit-mode cycle (review / auto / yolo) - reject / auto-approve / flip-to-auto messages - dashboard stopped, /restore code-mode-only - hash-memory note (with translated scope + verb) - bash-mode + memory-write failures - hook headers (UserPromptSubmit, Stop) - @mentions / @url expansion + failure - shell confirm (deny / always-allow / running / starting) - checkpoint saved - plan continue / stop / revise zh-CN translations for all 31 new keys. Test plan: full suite 2301 pass, tsc + biome clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Last big batch of hardcoded English in the chat UI. A Chinese user saw their own typed prompts in zh-CN but every system row from `App.tsx` (session banners, edit-mode flips, hook warnings, shell confirms, checkpoint saves) reverted to English.
What
Two patterns rolled together since they touched the same lines:
1. Wire existing `ui.*` keys
Seven keys in EN.ts / zh-CN.ts had been declared but never called — same dead-key pattern that bit the `loop.*` namespace before #445:
2. New `app.*` namespace
~24 keys for everything else:
zh-CN translations for all 31 added keys.
Test plan
What's still hardcoded (next PRs)