Improve crash reporting diagnostics / 增强崩溃上报诊断#4285
Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 905d93dc71
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
esengine
pushed a commit
that referenced
this pull request
Jun 14, 2026
Add a user-initiated performance-pressure report prompt when the desktop observes long tasks, event-loop lag, or high JS heap pressure. Captures coarse diagnostic context (timing, heap, visibility, network, breadcrumbs, version, OS), scrubs it through the existing crash-report pipeline as kind: performance, and lets the Worker/dashboard ingest it with no DB migration. Follow-up to #4285. Worker must be deployed before the desktop release that sends performance reports (old kind enum rejects them).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
distinto an ignoreddesktop/frontend/sourcemaps/<commit>/directory for private symbolication.Required production deployment order
This PR changes the live D1 schema. A maintainer with access to the Cloudflare account that owns the
reasonix-crashD1 database andreasonix-crash-reportWorker should run the migration before deploying the matching Worker.reasonix-crash.cd workers/crash-report npx wrangler d1 execute reasonix-crash --remote --file=migrate-structured-reports.sqlcd workers/crash-report npm run typecheck npm run deployImportant: do not run
schema.sqlagainst the existing production database as the upgrade path.schema.sqlis for fresh databases; existing production needsmigrate-structured-reports.sql. Running the new Worker before the migration can make crash report inserts fail because the new columns do not exist yet.Verification
go test ./...fromdesktoppnpm typecheckfromdesktop/frontendpnpm testfromdesktop/frontendpnpm buildfromdesktop/frontendnpm run typecheckfromworkers/crash-reportgit diff --checkdesktop/frontend/distcontains no.mapfiles after build