fix(desktop): auto-collapse completed todo panel#4271
Closed
GTC2080 wants to merge 1 commit into
Closed
Conversation
f4e0145 to
ea627db
Compare
This was referenced Jun 13, 2026
Collaborator
|
Thanks again for this contribution. I opened #4313 as an integration PR that includes this PR's completed-todo auto-collapse behavior and the direction of wiring todo visibility coverage into the regular frontend tests. #4313 combines that contribution with the plan-seed and restored-history work from #4159, #4230, and #4309, plus the additional success/error replay guards found during review. To keep review focused, I’m closing this PR as superseded by #4313. You are credited in the integration commit and PR body. |
esengine
pushed a commit
that referenced
this pull request
Jun 14, 2026
…#4313) Seed the agent's canonical todo state from approved plans so later complete_step calls advance the visible panel, and rebuild restored desktop history by replaying todo_write/complete_step only on explicitly successful tool results (missing or errored results no longer count as completed). Hide the panel once all todos are done, keyed to stable content rather than array identity. Integrates #4159, #4230, #4271, and #4309. Closes #4259 Closes #4105 Closes #4170 Closes #4241 Co-authored-by: JesonChou <51042251+JesonChou@users.noreply.github.com> Co-authored-by: ashishexee <144021866+ashishexee@users.noreply.github.com> Co-authored-by: GTC2080 <140309575+GTC2080@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4241.
Summary
N/Nlist visible.todo_writeand replay latercomplete_stepentries, so restored session history after restart matches the runtime host-advanced state.Root cause
The frontend treated any successful
todo_writewith at least one item as a visible panel. The final host-advanced list still contains todo entries, and restored history can contain the originaltodo_writeplus latercomplete_stepcalls, so a completed list could remain visible or reappear after restart.Verification
npm run test:todo-visibility(failed before the fix withtrue !== falsefor the all-completed list)npm run test:allnpm run buildgit diff --checkgo test ./...go test ./...indesktop/http://127.0.0.1:5174/, confirmed titleReasonix, and checked for zero console errors