fix(desktop): prevent command palette session text clipping#3962
Merged
esengine merged 1 commit intoJun 11, 2026
Merged
Conversation
esengine
approved these changes
Jun 11, 2026
esengine
left a comment
Owner
There was a problem hiding this comment.
Nice catch, and thanks for going the extra mile with a regression test — the cascade-order trap here (stale block later in the file silently winning) is exactly the kind of thing that needs one. The test wiring into test/test:all matches our harness style, LGTM.
Two tiny things the old block carried that I'll restore in a small follow-up (no action needed from you): the .palette__item:focus-visible outline, and the detached search button's hardcoded ⌘K label on Windows/Linux.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The command palette still had a legacy Command Palette CSS block later in
styles.css. Because it came after the current palette styles, it changed.palette__itemto a vertical layout. Recent-session rows then centered the icon above the title and let long session text or workspace paths overflow horizontally, clipping the leading characters (#3842).Fix
Removed the stale duplicate palette block so the current row layout and theme overrides remain the only palette styling. Added a frontend CSS regression test that checks palette rows keep a side-by-side icon/text layout and retain the title/path ellipsis constraints.
Tests
npm run test:allnpm run buildhttp://127.0.0.1:5184/?mock=demo: filtered the palette to a recent session and confirmed the row computes todisplay: flex; flex-direction: row, with no horizontal list overflow.Closes #3842