fix(desktop): close stuck thinking window after stream interruption (#3893)#3927
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-lands #3893 by @ashishexee — approved after re-review (all four earlier review points addressed: top-level watchdog effect with
lastTokenAtref and proper deps, controlled reasoning-card open state, focused-card-only ESC, plus the originalrunGuardedpanic recovery with emit-once tests). The branch conflicted with today's #3919 merge.Conflict resolution: the controlled open state now seeds from
item.streaming || defaultExpanded, so the newexpand_thinkingpreference still expands completed cards by default while a stuck streaming card stays user-closable — both features' intents preserved.Verified locally:
internal/controltests pass (including both new panic-recovery tests); touched frontend files parse clean. Author credit preserved.Closes #3893
Closes #3746