feat(desktop/cli): expand_thinking toggle + persist /verbose (#3396)#3919
Merged
Conversation
231079a to
7af4c13
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-lands #3396 by @ashishexee on top of current main-v2 — the
/sandboxsplit I asked for was done, and this carries exactly the promised scope: the desktopexpand_thinkingtoggle (#3303) plus/verbosepersistence viaui.show_reasoning(#3312).Conflict resolution (all adjacent-line drift): kept the
applyDesktopPreferencesrefactor andclearContextPendinggating inApp.tsx, keptShortcutLayoutalongside the newShowReasoningfield inUIConfig, kept both/sandboxand/verbosein the help view, and restored a closing brace the merge ate insettings_app.go. Verified locally: root module builds,internal/config+internal/clitests pass,desktopmodule builds and vets clean. Author credit preserved on the commit.#3827 covers the same
/verbosepersistence with a different config key (show_thinking) and will be closed as superseded once this lands.Closes #3396
Closes #3303
Closes #3312