Skip to content

[codex] Add desktop update check controls / 增加桌面更新检查控制#3888

Merged
SivanCola merged 1 commit into
main-v2from
codex/update-check-controls
Jun 11, 2026
Merged

[codex] Add desktop update check controls / 增加桌面更新检查控制#3888
SivanCola merged 1 commit into
main-v2from
codex/update-check-controls

Conversation

@SivanCola

@SivanCola SivanCola commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Add a desktop setting to enable or disable startup update checks while keeping manual checks available in Settings.
  • Add a dismiss action for update error banners so transient network failures do not pin the UI.
  • Keep settings helper text on one line with ellipsis and tooltip fallback, including the update preference row.
  • Restore the tracked dist/.gitkeep placeholder after production frontend builds so Vite can still clear stale assets without leaving a tracked deletion.

Validation

  • pnpm --dir desktop/frontend build
  • go test ./internal/config
  • go test . from the desktop module

Issues

Fixes #2822.
Fixes #3104.
Fixes #3699.

@github-actions github-actions Bot added v2 Go rewrite (1.x) — main-v2 branch, active development desktop Wails desktop app (desktop/**) config Configuration & setup (internal/config) labels Jun 10, 2026
This was referenced Jun 10, 2026
Closed
Closed
Closed
@SivanCola SivanCola marked this pull request as ready for review June 10, 2026 18:02
@SivanCola SivanCola requested a review from esengine as a code owner June 10, 2026 18:02
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Jun 10, 2026

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@SivanCola SivanCola enabled auto-merge June 10, 2026 18:07
@SivanCola SivanCola force-pushed the codex/update-check-controls branch from 8609ad1 to a59fbf4 Compare June 10, 2026 18:14
@SivanCola SivanCola force-pushed the codex/update-check-controls branch from a59fbf4 to 0adba93 Compare June 10, 2026 18:17
esengine
esengine approved these changes Jun 11, 2026
View reviewed changes

@esengine esengine left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well-rounded. The *bool default (nil → true via DesktopCheckUpdates) keeps existing users on auto-check, the AppBindings interface + mock are both updated so the bridge contract doesn't drift, and both locales are in sync. Gating the banner on startupUpdateChecksEnabled === true (initial null) is a nice touch — it avoids firing a check before the preference loads. Good Go test coverage on persistence + scoped render. The error-banner dismiss here supersedes #3708, which I'll close with thanks. Thanks!

@SivanCola SivanCola merged commit c55dec6 into main-v2 Jun 11, 2026
13 checks passed
@SivanCola SivanCola deleted the codex/update-check-controls branch June 11, 2026 01:41
This was referenced Jun 11, 2026
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@esengine esengine esengine approved these changes

Assignees

No one assigned

Labels

config Configuration & setup (internal/config) desktop Wails desktop app (desktop/**) v2 Go rewrite (1.x) — main-v2 branch, active development

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update error banner has no dismiss button — stuck on screen when offline [Bug]:更新失败也不能x掉 [Bug]: 异常更新提示

2 participants

@SivanCola @esengine