fix(desktop): 为更新错误横幅添加关闭按钮#3708
Conversation
5218575 to
b0801d3
Compare
|
Thanks for this — your diagnosis was exactly right, and reusing the existing Unfortunately #3888 (a larger update-controls PR that bundled the same dismiss button along with a startup-check setting) just landed and covers this same fix, so I'm closing this one to avoid a conflict-only rebase. Sorry for the overlap — that's on our queue ordering, not your patch. Your other banner/popover fixes (#3637, #3641, #3644) are still in my review queue and I'll get to them shortly. Please keep these focused quality-of-life fixes coming — they're appreciated. |
|
main-v2 absorbed a large batch of merges today and this branch now conflicts. Could you rebase onto the latest main-v2? The change itself is still wanted — once it's green I'll review promptly (fork CI gets approved as soon as you push). |
在 UpdateBanner 的 error case 中添加 dismiss 按钮，使用已有的 reset() 函数 将状态重置为 idle。网络异常时用户可以关闭错误横幅，不再被强制显示。 Fixes esengine#3699
b0801d3 to
7a18ac7
Compare
|
Thanks 鈥?your diagnosis and fix were right. The dismiss button landed on main-v2 in the meantime via the update-check controls work ( |
问题描述
当桌面应用启动时如果没有网络连接，自动更新检查会失败并显示错误横幅。该横幅无法关闭——只有"重试"按钮，没有关闭/取消选项。横幅会持续显示在所有标签页和会话中，直到网络连接恢复。
复现步骤
修复方案
在
UpdateBanner组件的errorcase 中添加 dismiss 按钮，使用已有的reset()函数将状态重置为 idle。与availablecase 中的关闭按钮行为一致。改动
desktop/frontend/src/components/UpdateBanner.tsx：解构时加入reset，在 Retry 按钮后添加 dismiss 按钮Fixes #3699
