Skip to content

chore(deps-dev): bump @types/react-dom to 19 to match @types/react#3793

Merged
esengine merged 2 commits into
main-v2from
chore/types-react-dom-19
Jun 10, 2026
Merged

chore(deps-dev): bump @types/react-dom to 19 to match @types/react#3793
esengine merged 2 commits into
main-v2from
chore/types-react-dom-19

Conversation

@esengine

Copy link
Copy Markdown
Owner

Follow-up to #3690 / #3691. #3690 bumped @types/react to 19 but left @types/react-dom at 18, whose types pin the @types/react peer to ^18 — so react/react-dom/@types/react are all 19 while @types/react-dom is 18. That's an ERESOLVE peer conflict; older npm (CI) tolerates it, but npm ci on newer npm fails without --legacy-peer-deps.

Bumps @types/react-dom to ^19.2.3 so the two React type packages agree. Verified locally: npm ci resolves cleanly without --legacy-peer-deps, and tsc (6.0.3) reports no new errors.

#3690 bumped @types/react to 19 but left @types/react-dom at 18, whose types
pin the @types/react peer to ^18 — an ERESOLVE conflict that npm ci tolerated
only on older npm. Bump @types/react-dom to 19.2.3 so the two react type
packages agree: npm ci now resolves without --legacy-peer-deps and the
frontend typechecks unchanged.
@esengine esengine requested a review from SivanCola as a code owner June 10, 2026 06:14
@github-actions github-actions Bot added v2 Go rewrite (1.x) — main-v2 branch, active development desktop Wails desktop app (desktop/**) labels Jun 10, 2026
@esengine esengine merged commit de2cdc5 into main-v2 Jun 10, 2026
13 checks passed
@esengine esengine deleted the chore/types-react-dom-19 branch June 10, 2026 06:23
SuMuxi66 pushed a commit to SuMuxi66/DeepSeek-Reasonix that referenced this pull request Jun 10, 2026
…sengine#3793)

* chore(deps-dev): bump @types/react-dom to 19 to match @types/react

esengine#3690 bumped @types/react to 19 but left @types/react-dom at 18, whose types
pin the @types/react peer to ^18 — an ERESOLVE conflict that npm ci tolerated
only on older npm. Bump @types/react-dom to 19.2.3 so the two react type
packages agree: npm ci now resolves without --legacy-peer-deps and the
frontend typechecks unchanged.

* chore(deps-dev): sync pnpm-lock.yaml for the @types/react-dom 19 bump

---------

Co-authored-by: reasonix <reasonix@deepseek.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

desktop Wails desktop app (desktop/**) v2 Go rewrite (1.x) — main-v2 branch, active development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant