Skip to content

Split /new and /clear session flows / 区分 /new 与 /clear 会话流程#3780

Merged
esengine merged 1 commit into
esengine:main-v2from
SivanCola:codex/clear-new-session-confirm
Jun 10, 2026
Merged

Split /new and /clear session flows / 区分 /new 与 /clear 会话流程#3780
esengine merged 1 commit into
esengine:main-v2from
SivanCola:codex/clear-new-session-confirm

Conversation

@SivanCola

Copy link
Copy Markdown
Collaborator

Summary

  • Split /new and /clear semantics: /new starts a new session and saves the transcript, while /clear discards the current context.
  • Add two-step /clear confirmation in the CLI TUI and an ASK-style in-app confirmation card in desktop.
  • Update desktop state reset, command help, docs, and regression coverage for the new session/context behavior.

Verification

  • pnpm --dir desktop/frontend build
  • isolated config run of go test ./internal/control ./internal/cli
  • go test ./... from desktop/
  • git diff --check origin/main-v2...HEAD

@SivanCola SivanCola requested a review from esengine as a code owner June 10, 2026 04:15
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@github-actions github-actions Bot added v2 Go rewrite (1.x) — main-v2 branch, active development desktop Wails desktop app (desktop/**) tui Terminal UI / CLI (internal/cli, internal/control) agent Core agent loop (internal/agent, internal/control) labels Jun 10, 2026
@SivanCola SivanCola force-pushed the codex/clear-new-session-confirm branch from 71a2864 to 2fd9783 Compare June 10, 2026 04:20

@esengine esengine left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good correctness fix — /new and /clear are now genuinely distinct: /new saves the transcript and rotates, /clear confirms then discards the current context without saving. ClearSession is gated on !running, only removes the current session's artifacts (history is untouched), and the confirmation card guards against accidents. Tests on both the controller and the TUI. Thanks!

@esengine esengine merged commit f45708c into esengine:main-v2 Jun 10, 2026
13 checks passed
SuMuxi66 pushed a commit to SuMuxi66/DeepSeek-Reasonix that referenced this pull request Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Core agent loop (internal/agent, internal/control) desktop Wails desktop app (desktop/**) tui Terminal UI / CLI (internal/cli, internal/control) v2 Go rewrite (1.x) — main-v2 branch, active development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants