Skip to content

test(desktop): use single-backslash inputs in the slashed golden tests#3761

Merged
esengine merged 1 commit into
main-v2from
fix/slashed-test-escaping
Jun 10, 2026
Merged

test(desktop): use single-backslash inputs in the slashed golden tests#3761
esengine merged 1 commit into
main-v2from
fix/slashed-test-escaping

Conversation

@esengine

Copy link
Copy Markdown
Owner

Follow-up to #3750 (test-only).

The \slashed -> \not golden cases wrote their braced inputs with a double backslash (\slashed{p}), while real model output is a single one (\slashed{p}). The conversion regex matched either way, so the tests passed — but they asserted a form the model never emits and left the production single-backslash braced form uncovered.

This switches those cases to single-backslash inputs and to the eq() helper the surrounding golden tests already use (the unbraced \slashed\epsilon(0) / \slashed a cases were already single-backslash). No production code changes; npm --prefix desktop/frontend test stays green (90/90).

The \slashed -> \not cases (#3750) wrote their braced inputs with a
double backslash (\slashed{p}); real model output is a single one. The
regex matched either way so the tests passed, but they exercised a form
the model never emits. Switch them to single-backslash inputs and the
eq() helper the surrounding golden tests already use.
@esengine esengine requested a review from SivanCola as a code owner June 10, 2026 02:57
@github-actions github-actions Bot added v2 Go rewrite (1.x) — main-v2 branch, active development desktop Wails desktop app (desktop/**) labels Jun 10, 2026
@esengine esengine merged commit 7359f75 into main-v2 Jun 10, 2026
14 checks passed
@esengine esengine deleted the fix/slashed-test-escaping branch June 10, 2026 03:01
SuMuxi66 pushed a commit to SuMuxi66/DeepSeek-Reasonix that referenced this pull request Jun 10, 2026
esengine#3761)

The \slashed -> \not cases (esengine#3750) wrote their braced inputs with a
double backslash (\slashed{p}); real model output is a single one. The
regex matched either way so the tests passed, but they exercised a form
the model never emits. Switch them to single-backslash inputs and the
eq() helper the surrounding golden tests already use.

Co-authored-by: reasonix <reasonix@deepseek.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

desktop Wails desktop app (desktop/**) v2 Go rewrite (1.x) — main-v2 branch, active development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant