test(desktop): use single-backslash inputs in the slashed golden tests#3761
Merged
Conversation
The \slashed -> \not cases (#3750) wrote their braced inputs with a double backslash (\slashed{p}); real model output is a single one. The regex matched either way so the tests passed, but they exercised a form the model never emits. Switch them to single-backslash inputs and the eq() helper the surrounding golden tests already use.
SuMuxi66
pushed a commit
to SuMuxi66/DeepSeek-Reasonix
that referenced
this pull request
Jun 10, 2026
esengine#3761) The \slashed -> \not cases (esengine#3750) wrote their braced inputs with a double backslash (\slashed{p}); real model output is a single one. The regex matched either way so the tests passed, but they exercised a form the model never emits. Switch them to single-backslash inputs and the eq() helper the surrounding golden tests already use. Co-authored-by: reasonix <reasonix@deepseek.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #3750 (test-only).
The
\slashed -> \notgolden cases wrote their braced inputs with a double backslash (\slashed{p}), while real model output is a single one (\slashed{p}). The conversion regex matched either way, so the tests passed — but they asserted a form the model never emits and left the production single-backslash braced form uncovered.This switches those cases to single-backslash inputs and to the
eq()helper the surrounding golden tests already use (the unbraced\slashed\epsilon(0)/\slashed acases were already single-backslash). No production code changes;npm --prefix desktop/frontend teststays green (90/90).