fix(control): don't auto-answer the ask tool in YOLO mode (#3624)#3712
Merged
Conversation
Controller.Ask checked bypassEnabled() and silently returned the first option of every question, so in YOLO mode the `ask` tool got a fake answer and the user never saw the prompt. Bypass is meant to skip tool-approval gates, not to answer the user's genuine questions. Remove both bypass checks (and the now unused recommendedAskAnswers helper); Ask always emits an AskRequest and waits for AnswerQuestion, even under bypass. Combines the minimal fix from #3709 (CVEngineer66) with the behavior tests from #3638 (warvyvr), dropping that PR's unrelated files. Closes #3624 Co-authored-by: CVEngineer66 <CVEngineer66@users.noreply.github.com> Co-authored-by: warvyvr <warvyvr@users.noreply.github.com>
This was referenced Jun 9, 2026
Removing the bypass checks from Ask left bypassEnabled with no callers (staticcheck unused).
SuMuxi66
pushed a commit
to SuMuxi66/DeepSeek-Reasonix
that referenced
this pull request
Jun 10, 2026
) (esengine#3712) * fix(control): don't auto-answer the ask tool in YOLO mode Controller.Ask checked bypassEnabled() and silently returned the first option of every question, so in YOLO mode the `ask` tool got a fake answer and the user never saw the prompt. Bypass is meant to skip tool-approval gates, not to answer the user's genuine questions. Remove both bypass checks (and the now unused recommendedAskAnswers helper); Ask always emits an AskRequest and waits for AnswerQuestion, even under bypass. Combines the minimal fix from esengine#3709 (CVEngineer66) with the behavior tests from esengine#3638 (warvyvr), dropping that PR's unrelated files. Closes esengine#3624 Co-authored-by: CVEngineer66 <CVEngineer66@users.noreply.github.com> Co-authored-by: warvyvr <warvyvr@users.noreply.github.com> * fix(control): drop now-unused bypassEnabled helper Removing the bypass checks from Ask left bypassEnabled with no callers (staticcheck unused). --------- Co-authored-by: reasonix <reasonix@deepseek.com> Co-authored-by: CVEngineer66 <CVEngineer66@users.noreply.github.com> Co-authored-by: warvyvr <warvyvr@users.noreply.github.com>
dorokuma
pushed a commit
to dorokuma/DeepSeek-Reasonix
that referenced
this pull request
Jun 10, 2026
) (esengine#3712) * fix(control): don't auto-answer the ask tool in YOLO mode Controller.Ask checked bypassEnabled() and silently returned the first option of every question, so in YOLO mode the `ask` tool got a fake answer and the user never saw the prompt. Bypass is meant to skip tool-approval gates, not to answer the user's genuine questions. Remove both bypass checks (and the now unused recommendedAskAnswers helper); Ask always emits an AskRequest and waits for AnswerQuestion, even under bypass. Combines the minimal fix from esengine#3709 (CVEngineer66) with the behavior tests from esengine#3638 (warvyvr), dropping that PR's unrelated files. Closes esengine#3624 Co-authored-by: CVEngineer66 <CVEngineer66@users.noreply.github.com> Co-authored-by: warvyvr <warvyvr@users.noreply.github.com> * fix(control): drop now-unused bypassEnabled helper Removing the bypass checks from Ask left bypassEnabled with no callers (staticcheck unused). --------- Co-authored-by: reasonix <reasonix@deepseek.com> Co-authored-by: CVEngineer66 <CVEngineer66@users.noreply.github.com> Co-authored-by: warvyvr <warvyvr@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug (#3624)
In YOLO/bypass mode, when the agent calls the
asktool to get a user decision, no prompt appears and the agent silently receives the first option. Bypass is meant to skip tool-approval gates, not to answer the user's genuine questions — soaskwas being defeated.Fix
Controller.Askremoved bothbypassEnabled()short-circuits (and the now-unusedrecommendedAskAnswershelper). Ask always emits anAskRequestand waits forAnswerQuestion, even under bypass.Provenance — combining the two open PRs for this issue
Two PRs targeted #3624; neither was mergeable alone:
Asknow blocks).wow.md,README.md,.gitignore).This PR takes #3709's clean fix and #3638's behavior tests (
TestBypassDoesNotAutoAnswerAsk,TestAskSerializesBehindPromptLockEvenWithBypass), dropping the stray files. Credit to both authors via Co-authored-by.Test plan
go test ./internal/controlgreen; both new tests pass; gofmt/vet clean.