fix(cli): disable codegraph in ACP session config test#3663
Merged
Conversation
TestACPFactoryLoadsSessionCwdProjectConfig builds a full controller via boot.Build with the default config, which starts the codegraph serve daemon when the binary is installed. The daemon opens <workspaceRoot>/.codegraph/codegraph.db and on Windows holds the handle past Close, so t.TempDir cleanup fails with "being used by another process". The test only exercises ACP project-command loading, so turn codegraph off — matching the boot tests' convention.
SuMuxi66
pushed a commit
to SuMuxi66/DeepSeek-Reasonix
that referenced
this pull request
Jun 10, 2026
TestACPFactoryLoadsSessionCwdProjectConfig builds a full controller via boot.Build with the default config, which starts the codegraph serve daemon when the binary is installed. The daemon opens <workspaceRoot>/.codegraph/codegraph.db and on Windows holds the handle past Close, so t.TempDir cleanup fails with "being used by another process". The test only exercises ACP project-command loading, so turn codegraph off — matching the boot tests' convention. Co-authored-by: reasonix <reasonix@deepseek.com>
dorokuma
pushed a commit
to dorokuma/DeepSeek-Reasonix
that referenced
this pull request
Jun 10, 2026
TestACPFactoryLoadsSessionCwdProjectConfig builds a full controller via boot.Build with the default config, which starts the codegraph serve daemon when the binary is installed. The daemon opens <workspaceRoot>/.codegraph/codegraph.db and on Windows holds the handle past Close, so t.TempDir cleanup fails with "being used by another process". The test only exercises ACP project-command loading, so turn codegraph off — matching the boot tests' convention. Co-authored-by: reasonix <reasonix@deepseek.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestACPFactoryLoadsSessionCwdProjectConfigfails deterministically on any machine that has the codegraph binary installed (and intermittently on others). It builds a full controller throughboot.Buildwith the default config, which starts thecodegraph serve --mcpdaemon. The daemon opens<workspaceRoot>/.codegraph/codegraph.db, and on Windows that handle outlivesctrl.Close(), so thet.TempDircleanup of the workspace root fails withunlinkat ... The process cannot access the file because it is being used by another process.The test only verifies that an ACP session loads project commands from cwd — codegraph is irrelevant to it. Disable codegraph in the test's
reasonix.toml, matching the convention the boot tests already use.Test plan
go test ./internal/cli -run '^TestACPFactoryLoadsSessionCwdProjectConfig$' -count=5-> 5/5 FAIL (db lock) before;-count=10-> 10/10 pass after, ~0.86s (no daemon).go test ./internal/cligreen.