Skip to content

fix(memory): keep forget failures inside the memory UI#3662

Merged
esengine merged 1 commit into
esengine:main-v2from
paradoxSCH:fix-3642-memory-forget-crash
Jun 9, 2026
Merged

fix(memory): keep forget failures inside the memory UI#3662
esengine merged 1 commit into
esengine:main-v2from
paradoxSCH:fix-3642-memory-forget-crash

Conversation

@paradoxSCH

Copy link
Copy Markdown
Contributor

Summary

  • catch memory add/save/forget bridge failures inside the desktop memory UI so a failed delete no longer becomes an unhandled rejection crash page
  • show the operation error inline in the memory panel/settings page
  • make memory.Store.Delete retry once after restoring owner write permissions on the memory file and containing directory

Fixes #3642

Tests

  • go test ./internal/memory -count=1
  • npm run check:css
  • git diff --check

Notes

  • npm run typecheck is currently blocked by existing unrelated errors (missing generated Wails modules, existing nullable ref type errors, and @tanstack/react-virtual type resolution); no MemoryPanel errors were reported when filtering the output.
  • local commit/push hooks still fail because they try to run npm from the repository root where package.json is absent, so this branch was committed and pushed with --no-verify after the checks above.

@github-actions github-actions Bot added v2 Go rewrite (1.x) — main-v2 branch, active development desktop Wails desktop app (desktop/**) labels Jun 9, 2026
@paradoxSCH paradoxSCH marked this pull request as ready for review June 9, 2026 10:15
@esengine esengine merged commit 680945f into esengine:main-v2 Jun 9, 2026
10 checks passed
SuMuxi66 pushed a commit to SuMuxi66/DeepSeek-Reasonix that referenced this pull request Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

desktop Wails desktop app (desktop/**) v2 Go rewrite (1.x) — main-v2 branch, active development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: 删除记忆时报错

2 participants