fix(serve): restore query helper#3658
Merged
esengine merged 1 commit intoJun 9, 2026
Merged
Conversation
esengine
approved these changes
Jun 9, 2026
esengine
left a comment
Owner
There was a problem hiding this comment.
Verified end-to-end. Reproduced #3645: the embedded serve UI references $ 51 times starting at const log = $('#log') but never defines it (only $$ was defined), so the page throws ReferenceError: $ is not defined and the whole script dies. With the one-line helper restored, the regression test and the full serve package pass. Thanks for the fix and the test.
SuMuxi66
pushed a commit
to SuMuxi66/DeepSeek-Reasonix
that referenced
this pull request
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$query helper in the embedded serve-mode web UI$and$$helpers are defined before the page uses themFixes #3645
Tests
go test ./internal/serve -run TestServeIndexDefinesQueryHelpers -count=1go test ./internal/serve -count=1Notes
package.jsonis absent; the relevant Go tests above were run manually