fix(desktop): let macOS system quit bypass background close#3203
Merged
Conversation
Collaborator
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. You're on a roll. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
esengine
approved these changes
Jun 5, 2026
esengine
left a comment
Owner
There was a problem hiding this comment.
macOS 系统退出(Dock/菜单/Cmd-Q)经 applicationShouldTerminate: + WailsContext.Quit 双重 swizzle 置标记，beforeClose 消费后放行；普通关闭后台行为不变并有回归测试。平台约束靠 _darwin 文件名后缀，三平台 CI 全绿。合并。
esengine
added a commit
that referenced
this pull request
Jun 5, 2026
Add a desktop close-to-tray option: closing the window can hide to a tray icon (Windows/Linux menu with Open/Quit, platform guards) instead of quitting. Rebased onto main-v2 with the macOS system-quit hook (#3203) — both run at startup; beforeClose keeps system-quit bypass ahead of close-to-background. Original author: @wade19990814-hue. Closes #3030
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests