Skip to content

fix: show sent desktop messages immediately#3056

Closed
YoungDan-hero wants to merge 1 commit into
esengine:main-v2from
YoungDan-hero:dev-1
Closed

fix: show sent desktop messages immediately#3056
YoungDan-hero wants to merge 1 commit into
esengine:main-v2from
YoungDan-hero:dev-1

Conversation

@YoungDan-hero

Copy link
Copy Markdown
Contributor

Desktop chat waited for the backend's first real event before adding the user's submitted message to the transcript. This made short prompts look delayed whenever the bridge, provider, or model had startup latency.

Show the submitted message right away with a pending state so the UI responds immediately. Confirm that message when the first backend event arrives, remove it if the user cancels before confirmation, and mark it failed only when submission fails before the backend has accepted the turn.

Add reducer coverage for immediate display, confirmation without duplicates, cancel-before-confirmation, early submit failure, and late submit rejection.

Desktop chat waited for the backend's first real event before adding the user's submitted message to the transcript. This made short prompts look delayed whenever the bridge, provider, or model had startup latency.

Show the submitted message right away with a pending state so the UI responds immediately. Confirm that message when the first backend event arrives, remove it if the user cancels before confirmation, and mark it failed only when submission fails before the backend has accepted the turn.

Add reducer coverage for immediate display, confirmation without duplicates, cancel-before-confirmation, early submit failure, and late submit rejection.

Co-authored-by: Cursor <cursoragent@cursor.com>

@esengine esengine left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the diff: the fix is correct, focused, and CI is green. Approving for merge.

@esengine

esengine commented Jun 9, 2026

Copy link
Copy Markdown
Owner

Thanks for this — the change reviewed cleanly and CI was green. But #3603 just merged into main-v2 and touches the same files (useController.ts, package.json, and the lockfile), so this PR now conflicts with main-v2. Could you rebase onto the latest main-v2 and resolve the conflicts? It should be ready to merge right after. 🙏

lanshi17 pushed a commit to lanshi17/DeepSeek-Reasonix that referenced this pull request Jun 11, 2026
Submit rejections were swallowed, leaving an optimistic user bubble
that looked delivered while the backend never saw the turn. Mark the
bubble failed, append a warning notice, and stop the running
indicator when the bridge call rejects before the first backend
event; confirmed turns are unaffected.

Closes esengine#3056

Co-authored-by: reasonix <reasonix@deepseek.com>
Co-authored-by: luffy <1292867089@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v2 Go rewrite (1.x) — main-v2 branch, active development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants