fix(desktop): prevent React #31 when MCP config contains non-string items (#1295)#1394
Merged
Merged
Conversation
…string items (esengine#1295) Root cause: readConfig() does runtime JSON.parse without validation, so config.json's mcp array can contain objects even though typed as string[]. The summarizeMcpSpec catch block then returned summary: raw directly, which leaked objects into JSX and triggered React error esengine#31. Fixes (4-layer defense): 1. summarizeMcpSpec catch block now stringifies non-string raw values using JSON.stringify(raw) ?? String(raw), so summary is always a string. 2. emitMcpSpecs filters cfg.mcp with typeof raw === "string" before mapping, preventing bad items from reaching the renderer at all. 3. CtxTools (context-panel.tsx) renders summary defensively. 4. PageMCP (settings.tsx) renders name/summary defensively. Added regression test: tests/mcp-desktop-react31.test.ts Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This was referenced May 20, 2026
esengine
added a commit
that referenced
this pull request
May 20, 2026
) readConfig() previously cast JSON.parse output to ReasonixConfig with no runtime validation. Hand-edited config.json could put objects, numbers, or null into fields typed as `string[]` (mcp, mcpDisabled, recentWorkspaces, skills.paths), corrupting downstream consumers — see #1295 / #1394 where non-string mcp items reached JSX and crashed the desktop tools panel. - New `sanitizeStringArrayField` in `src/config.ts` drops non-string items at the boundary and warns once per field with the file path + dropped count. - Removes the now-dead downstream defenses (#1394's filter in `emitMcpSpecs`, `typeof` ternaries in `context-panel.tsx` / `settings.tsx`, `summarizeMcpSpec`'s non-string catch). `summarizeMcpSpec` no longer needs to be exported. - Test file renamed to `config-sanitize-string-arrays.test.ts` and rewritten against `readConfig` (where the validation actually lives). Closes #1395
ChasLui
pushed a commit
to ChasLui/DeepSeek-Reasonix
that referenced
this pull request
May 23, 2026
…string items (esengine#1394) Fixes esengine#1295 — Desktop MCP tools panel crashes with React error esengine#31 ("Objects are not valid as a React child") when `config.json` contains non-string items in the `mcp` array. Root cause: `readConfig()` does `JSON.parse` without runtime validation, so `cfg.mcp` can contain objects even though it's typed as `string[]`. When `summarizeMcpSpec()` threw on these object inputs, its catch block returned `summary: raw` directly, leaking objects into JSX. Fix: - `summarizeMcpSpec` catch block — stringify non-string `raw` before returning. - `emitMcpSpecs` — filter `cfg.mcp` to string items before mapping. - `CtxTools` / `PageMCP` — render `summary` / `name` only when string. - Regression test in `tests/mcp-desktop-react31.test.ts`. Follow-up tracked separately: tighten `readConfig` with zod schema validation so this boundary check lives in one place.
ChasLui
pushed a commit
to ChasLui/DeepSeek-Reasonix
that referenced
this pull request
May 23, 2026
…engine#1396) readConfig() previously cast JSON.parse output to ReasonixConfig with no runtime validation. Hand-edited config.json could put objects, numbers, or null into fields typed as `string[]` (mcp, mcpDisabled, recentWorkspaces, skills.paths), corrupting downstream consumers — see esengine#1295 / esengine#1394 where non-string mcp items reached JSX and crashed the desktop tools panel. - New `sanitizeStringArrayField` in `src/config.ts` drops non-string items at the boundary and warns once per field with the file path + dropped count. - Removes the now-dead downstream defenses (esengine#1394's filter in `emitMcpSpecs`, `typeof` ternaries in `context-panel.tsx` / `settings.tsx`, `summarizeMcpSpec`'s non-string catch). `summarizeMcpSpec` no longer needs to be exported. - Test file renamed to `config-sanitize-string-arrays.test.ts` and rewritten against `readConfig` (where the validation actually lives). Closes esengine#1395
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1295 — Desktop MCP tools panel crashes with React error #31 ("Objects are not valid as a React child") when
config.jsoncontains non-string items in themcparray.Root Cause
readConfig()doesJSON.parsewithout runtime validation, soconfig.json'smcparray can contain objects even though it's typed asstring[]. WhensummarizeMcpSpec()threw on these object inputs, its catch block returnedsummary: rawdirectly, leaking objects into JSX.Fix (4-layer defense)
summarizeMcpSpeccatch block — stringifies non-stringrawvalues usingJSON.stringify(raw) ?? String(raw), sosummaryis always a string.emitMcpSpecsfilter — filterscfg.mcpwithtypeof raw === "string"before mapping, preventing bad items from reaching the renderer at all.CtxToolsdefensive render (context-panel.tsx) — renderssummaryonly if it's a string.PageMCPdefensive render (settings.tsx) — rendersname/summaryonly if they're strings.Test Plan
tests/mcp-desktop-react31.test.tsnpm run verifypasses (build + lint + typecheck + 3343 tests)🤖 Generated with Claude Code