chore(java): clean up comment style + isolate searchProject tests#1363
Merged
Conversation
added 2 commits
May 19, 2026 18:08
#1344 followed conventions from a different codebase — `// ── types ──` banner separators, multi-line module-header essays, and JSDoc-style `@param`/`@returns` text restating type signatures. CLAUDE.md bans all three. Trim to plain code with comments only on hidden constraints or non-obvious invariants. No behavior change; all 41 java-source tests still pass.
Three searchProject tests ("returns not-found", "skips common non-source
directories", "handles empty project root gracefully") were walking the
real ~/.m2 / ~/.gradle defaults — fine on a fresh CI runner, flaky on a
dev machine with a populated cache under full-suite I/O contention.
- Pass repoPaths: [] so the not-found path skips the jar scan entirely.
- Bump per-test timeout to 30s as a defensive cap; the searches now run
in ms, but Windows AV scanning of fresh tmp dirs can still spike.
ChasLui
pushed a commit
to ChasLui/DeepSeek-Reasonix
that referenced
this pull request
May 23, 2026
…engine#1363) * chore(java): strip section-banner comments and module-header essays esengine#1344 followed conventions from a different codebase — `// ── types ──` banner separators, multi-line module-header essays, and JSDoc-style `@param`/`@returns` text restating type signatures. CLAUDE.md bans all three. Trim to plain code with comments only on hidden constraints or non-obvious invariants. No behavior change; all 41 java-source tests still pass. * test(java-source): isolate project-search tests from real ~/.m2 cache Three searchProject tests ("returns not-found", "skips common non-source directories", "handles empty project root gracefully") were walking the real ~/.m2 / ~/.gradle defaults — fine on a fresh CI runner, flaky on a dev machine with a populated cache under full-suite I/O contention. - Pass repoPaths: [] so the not-found path skips the jar scan entirely. - Bump per-test timeout to 30s as a defensive cap; the searches now run in ms, but Windows AV scanning of fresh tmp dirs can still spike. --------- Co-authored-by: reasonix <reasonix@deepseek.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/.m2` / `/.gradle` defaults — they were walking real caches and timing out on dev machines under full-suite I/O contention. Pass `repoPaths: []` plus a defensive 30s per-test cap.No behavior change in production code. 41 java-source tests still pass.
Test plan