Skip to content

fix(cli): add opt-out for terminal mouse tracking#1345

Merged
esengine merged 1 commit into
esengine:mainfrom
J3y0r:fix/key-mouse
May 20, 2026
Merged

fix(cli): add opt-out for terminal mouse tracking#1345
esengine merged 1 commit into
esengine:mainfrom
J3y0r:fix/key-mouse

Conversation

@J3y0r

@J3y0r J3y0r commented May 19, 2026

Copy link
Copy Markdown

What

  • Add --no-mouse to bare, code, and chat CLI entrypoints.
  • Thread the opt-out through code mode into chat mode so SGR mouse tracking is skipped when requested.
    • Add English/Chinese help text and tests for bare routing plus chat mouse-mode behavior.

Why

#1337

How to verify

Checklist

  • [ ✓ ] npm run verify passes locally (lint + typecheck + tests + comment-policy gate)
  • [ ✓ ] No Co-Authored-By: Claude trailer in commits
  • [ ✓ ] Comments follow CONTRIBUTING.md (no module-essay headers, no incident history)
  • [ ✓ ] No edits to CHANGELOG.md — release notes are maintainer-written at release time

@esengine esengine merged commit 71b0ffa into esengine:main May 20, 2026
4 checks passed
@esengine

Copy link
Copy Markdown
Owner

Thanks @J3y0r — clean surgical fix. The flag got dropped in 0.46.0 under the assumption Ink would take over mouse handling end-to-end, but the enableMouseMode() call in chat.tsx survived, so Windows Terminal users actually lost drag-select / right-click-paste with no way to opt out. Re-threading the flag through the three CLI entrypoints + gating on both opts.noMouse and cfg.mouseTracking is exactly the right shape.

ChasLui pushed a commit to ChasLui/DeepSeek-Reasonix that referenced this pull request May 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants