You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks @wade19990814-hue — this stays exactly inside the scope we agreed on in #1218: a thin desktop front-end over the existing loadQQConfig / saveQQConfig path, no new secret store, no chat-surface bleed, and the underlying channel implementation untouched. The setDesktopQQEnabled guard refusing to flip the flag without credentials is a nice safety net. Tests cover the right boundaries. Merged. Closes #1218.
One small thing for a follow-up only if you feel like it (not blocking): in the desktop context qq_connect flips the persisted enabled flag rather than driving a live websocket (the desktop process doesn't host a QQ runtime today). The "Connected" / "Disconnected" labels mean "enabled in config" — which is the right behaviour for the scope we picked, but if it turns out to confuse users the labels could shift to "Enabled" / "Disabled" later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1218.
Summary
QQ Channelrow at the bottom ofSettings -> GeneralApp ID,App Secret, andSandboxloadQQConfig/saveQQConfigpath with no new desktop secret storeNotes
Verification
npm test -- --run tests/qq-config.test.ts tests/desktop-qq-config.test.ts tests/desktop-qq-settings-ui.test.tsnpm run typechecknpm run lintnpm --prefix desktop run buildLocal verify note
npm run verifystill hits the existingtests/code-prompt.test.tsfailure in this environment (expected 30744 to be less than 29387)