Skip to content

feat: config validation bin#139

Merged
aramalipoor merged 11 commits intoerpc:mainfrom
KONFeature:feat/validation-cli
Jan 1, 2025
Merged

feat: config validation bin#139
aramalipoor merged 11 commits intoerpc:mainfrom
KONFeature:feat/validation-cli

Conversation

@KONFeature
Copy link
Copy Markdown
Contributor

@KONFeature KONFeature commented Dec 29, 2024 •
edited
Loading

Adding a CLI binary to validate config file + provide a few stats / warn about the config

Stats provided:

  • Orphan rate limits budget (warn)
  • Rate limits + associated resources (debug)
  • Total number of projects (info)
  • Projects info (upstreams, networks) (info)

The CLI is exported via goreleaser for now, so it can be used by downloading the executable matching the computer spec on the release page

It could also be added to the typescript package via a small install script that would download the right executable depending on the dev computer

@KONFeature KONFeature marked this pull request as draft December 29, 2024 14:39
@KONFeature KONFeature marked this pull request as ready for review December 30, 2024 11:32
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 30, 2024 •
edited
Loading

ℹ️ Benchmark Results (null)

goos: linux
goarch: amd64
pkg: github.com/erpc/erpc/health
cpu: AMD EPYC 7763 64-Core Processor                
                                 │ /tmp/benchmark-pr.txt │
                                 │        sec/op         │
RecordUpstreamRequest-8                     79.08n ± 11%
RecordUpstreamDuration-8                    324.3n ±  6%
RecordUpstreamFailure-8                     77.87n ±  1%
GetUpstreamMethodMetrics-8                  11.65n ±  1%
TrackerMixed-8                              113.1n ±  0%
RecordAndGetMetrics-8                       317.2n ±  2%
ReadHeavy-8                                 39.98n ±  0%
WriteHeavy-8                                276.0n ±  1%
HighConcurrency/goroutines-10-8             3.162µ ±  1%
HighConcurrency/goroutines-50-8             15.83µ ±  1%
HighConcurrency/goroutines-100-8            31.35µ ±  1%
HighConcurrency/goroutines-200-8            62.66µ ±  1%
HighConcurrency/goroutines-500-8            156.3µ ±  1%
BlockNumberUpdates-8                        219.2n ±  1%
HotKeyAccess-8                              359.6n ±  6%
FullRequestFlow-8                           135.7µ ±  0%
ConcurrentCordonOperations-8                123.2n ±  0%
geomean                                     906.0n

                                 │ /tmp/benchmark-pr.txt │
                                 │         B/op          │
RecordUpstreamRequest-8                    0.000 ±  0%
RecordUpstreamDuration-8                   0.000 ±  0%
RecordUpstreamFailure-8                    0.000 ±  0%
GetUpstreamMethodMetrics-8                 0.000 ±  0%
TrackerMixed-8                             0.000 ±  0%
RecordAndGetMetrics-8                      0.000 ±  0%
ReadHeavy-8                                0.000 ±  0%
WriteHeavy-8                               0.000 ±  0%
HighConcurrency/goroutines-10-8            10.50 ± 14%
HighConcurrency/goroutines-50-8            67.50 ± 14%
HighConcurrency/goroutines-100-8           153.0 ±  8%
HighConcurrency/goroutines-200-8           362.5 ± 11%
HighConcurrency/goroutines-500-8          1022.5 ±  8%
BlockNumberUpdates-8                       1.000 ±  0%
HotKeyAccess-8                             2.000 ±  0%
FullRequestFlow-8                          949.0 ±  4%
ConcurrentCordonOperations-8               8.000 ±  0%
geomean                                                ¹
¹ summaries must be >0 to compute geomean

                                 │ /tmp/benchmark-pr.txt │
                                 │       allocs/op       │
RecordUpstreamRequest-8                    0.000 ±  0%
RecordUpstreamDuration-8                   0.000 ±  0%
RecordUpstreamFailure-8                    0.000 ±  0%
GetUpstreamMethodMetrics-8                 0.000 ±  0%
TrackerMixed-8                             0.000 ±  0%
RecordAndGetMetrics-8                      0.000 ±  0%
ReadHeavy-8                                0.000 ±  0%
WriteHeavy-8                               0.000 ±  0%
HighConcurrency/goroutines-10-8            0.000 ±  0%
HighConcurrency/goroutines-50-8            1.000 ±   ?
HighConcurrency/goroutines-100-8           2.000 ±  0%
HighConcurrency/goroutines-200-8           6.000 ± 17%
HighConcurrency/goroutines-500-8           17.00 ± 12%
BlockNumberUpdates-8                       0.000 ±  0%
HotKeyAccess-8                             0.000 ±  0%
FullRequestFlow-8                          16.00 ±  6%
ConcurrentCordonOperations-8               0.000 ±  0%
geomean                                                ¹
¹ summaries must be >0 to compute geomean

aramalipoor
aramalipoor reviewed Dec 31, 2024
View reviewed changes
aramalipoor
aramalipoor reviewed Dec 31, 2024
View reviewed changes
aramalipoor
aramalipoor reviewed Dec 31, 2024
View reviewed changes
aramalipoor
aramalipoor reviewed Dec 31, 2024
View reviewed changes
@aramalipoor aramalipoor merged commit f2c5158 into erpc:main Jan 1, 2025
aramalipoor pushed a commit that referenced this pull request Jan 8, 2025
@KONFeature @aramalipoor
feat: add config validation command (#139)
726a114
zekiblue pushed a commit to zekiblue/erpc that referenced this pull request May 6, 2025
@KONFeature
feat: add config validation command (erpc#139)
2cfaeb9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aramalipoor aramalipoor aramalipoor left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@KONFeature @aramalipoor