Fix minimize-to-tray setting ignored in both apps (#53)#55
Merged
erikdarlingdata merged 1 commit intodevfrom Feb 16, 2026
Merged
Fix minimize-to-tray setting ignored in both apps (#53)#55erikdarlingdata merged 1 commit intodevfrom
erikdarlingdata merged 1 commit intodevfrom
Conversation
#53) Dashboard: SettingsWindow was creating its own UserPreferencesService instance, so preference changes weren't visible to MainWindow's instance (stale in-memory cache). Now shares the same instance via constructor injection. Lite: SystemTrayService always hid window on minimize with no preference check. Added App.MinimizeToTray property, wired to settings.json (key already existed but was unused), added checkbox to Settings UI. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SettingsWindowwas creating its ownUserPreferencesServiceinstance, so toggling "Minimize to system tray" off had no effect —MainWindowstill read the stale in-memory value (true). Fixed by sharing the same instance via constructor injection.SystemTrayServicealways hid the window on minimize with no preference check. AddedApp.MinimizeToTrayproperty wired tosettings.json(key already existed but was unused), added checkbox to Settings UI.Test plan
Fixes #53
🤖 Generated with Claude Code