Skip to content

Move Default Trace tabs from Resource Metrics to Overview#175

Merged
erikdarlingdata merged 1 commit intodevfrom
feature/trace-tab-placement
Feb 19, 2026
Merged

Move Default Trace tabs from Resource Metrics to Overview#175
erikdarlingdata merged 1 commit intodevfrom
feature/trace-tab-placement

Conversation

@erikdarlingdata
Copy link
Owner

Summary

  • Moves Default Trace Events and Trace Analysis tabs from Resource Metrics to Overview section (fixes [BUG] Default Trace Analysis tab should be under Overview, not Resource Metrics #169)
  • Extracts trace tabs into new DefaultTraceContent UserControl following existing patterns (DailySummaryContent, CriticalIssuesContent)
  • Removes dead column filter popup infrastructure from ResourceMetricsContent (no longer needed)
  • Wires up Initialize, SetTimeRange, and RefreshAllDataAsync in ServerTab

Test plan

  • Launch Dashboard, verify Default Trace tab appears under Overview
  • Verify Default Trace Events and Trace Analysis sub-tabs load data correctly
  • Verify Resource Metrics tab no longer shows trace tabs
  • Verify global time range applies to trace tabs
  • Verify tab-specific refresh works for Overview

🤖 Generated with Claude Code

Default Trace Events and Trace Analysis tabs belong under Overview, not
Resource Metrics. Extracted into new DefaultTraceContent UserControl
following the same pattern as DailySummaryContent and CriticalIssuesContent.
Removed dead column filter popup infrastructure from ResourceMetricsContent.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@erikdarlingdata erikdarlingdata merged commit 66d4048 into dev Feb 19, 2026
3 checks passed
@erikdarlingdata erikdarlingdata deleted the feature/trace-tab-placement branch February 19, 2026 23:08
erikdarlingdata added a commit that referenced this pull request Feb 19, 2026
The view report.long_running_query_patterns aggregates ALL time then
takes TOP 50 by avg_duration_ms. When recent patterns are shorter than
old load test patterns, the dashboard's time filter eliminates all 50
rows. Fix by inlining the query with time filter inside the CTE so
aggregation only considers data within the selected time range.

The second part of #168 (Trace Analysis in wrong location) was already
fixed in PR #175.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
erikdarlingdata added a commit that referenced this pull request Feb 19, 2026
…176)

The view report.long_running_query_patterns aggregates ALL time then
takes TOP 50 by avg_duration_ms. When recent patterns are shorter than
old load test patterns, the dashboard's time filter eliminates all 50
rows. Fix by inlining the query with time filter inside the CTE so
aggregation only considers data within the selected time range.

The second part of #168 (Trace Analysis in wrong location) was already
fixed in PR #175.

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant