Skip to content

Fix eth tests#8

Merged
AlexeyAkhunov merged 1 commit into
masterfrom
fix_eth_tests
May 31, 2019
Merged

Fix eth tests#8
AlexeyAkhunov merged 1 commit into
masterfrom
fix_eth_tests

Conversation

@AlexeyAkhunov

Copy link
Copy Markdown
Contributor

No description provided.

@AlexeyAkhunov AlexeyAkhunov merged commit 40e8807 into master May 31, 2019
enriavil1 pushed a commit that referenced this pull request Jan 29, 2022
BlinkyStitt pushed a commit to llamanodes/erigon that referenced this pull request Jan 3, 2023
mardizzone/pos-944: snyk and govuln integration
pgebal pushed a commit to imapp-pl/erigon that referenced this pull request Jan 16, 2023
Add testcase for SSZ encoding. Add JSON marshal. Add encoding from Block
pcw109550 pushed a commit to sunnyside-io/erigon that referenced this pull request May 19, 2023
battlmonstr pushed a commit that referenced this pull request Sep 14, 2023
SubPool object, PromoteStep func and fuzzing example
revitteth referenced this pull request in 0xPolygon/cdk-erigon Dec 12, 2023
Incremental intermediate hashes & Tip Sync
taratorio pushed a commit that referenced this pull request Jul 23, 2024
Improvement to magnet link generation
AskAlexSharov added a commit that referenced this pull request Apr 21, 2025
# This is the 1st commit message:

save

# This is the commit message #2:

save

# This is the commit message #3:

save

# This is the commit message #4:

save

# This is the commit message #5:

save

# This is the commit message #6:

save

# This is the commit message #7:

save

# This is the commit message #8:

save
AskAlexSharov added a commit that referenced this pull request Jun 27, 2025
# This is the 1st commit message:

save

# This is the commit message #2:

save

# This is the commit message #3:

save

# This is the commit message #4:

save

# This is the commit message #5:

save

# This is the commit message #6:

save

# This is the commit message #7:

save

# This is the commit message #8:

save

# This is the commit message #9:

save

# This is the commit message #10:

BodyOnlyTxn: for when only TxCount and BaseDataID is needed from blocks (#15599)

issue: #15516
# This is the commit message #11:

save

# This is the commit message #12:

save

# This is the commit message #13:

save

# This is the commit message #14:

save

# This is the commit message #15:

save

# This is the commit message #16:

save

# This is the commit message #17:

save

# This is the commit message #18:

save
bloxster added a commit that referenced this pull request Apr 3, 2026
Apply PR additions: errors #8 (Docker UID/GID) and #9 (libsilkworm_capi.so)
AskAlexSharov pushed a commit that referenced this pull request Apr 3, 2026
## Summary

Ports the full Help Center content to `release/3.4`, mirroring what was
merged to `main` via PR #20267.

Changes per file:

- **best-practices.md**: added "Harden Public RPC Endpoints" row +
Section 6 (Advanced Performance Tricks with vmtouch,
ERIGON_SNAPSHOT_MADV_RND, db.pagesize)
- **common-errors-and-solutions.md**: added errors #8 (Docker UID/GID
mismatch) and #9 (libsilkworm_capi.so missing)
- **frequently-asked-questions-faqs.md**: added FAQ #21 (historical
block queries / pruning) and #22 (ARM/RPi feasibility)
- **known-issues.md**: improved vmmap/pmap section (macOS vs Linux),
removed DOCKER_BUILDKIT env vars, added `--db.pagesize` section (default
16KB)
- **troubleshooting.md**: added Diagnostics section (SIGUSR1 goroutine
dump, pprof CPU/heap capture) and Hetzner firewall note

All content is identical to `main` post-#20267, with yperbasis review
fixes already applied (broken erigon-lib link removed, pprof addr/port
flags documented).

## Test plan

- [ ] Verify all 5 files render correctly in GitBook preview
- [ ] No broken internal links
- [ ] Content consistent with release/3.3 (PR #20263) and main

🤖 Generated with [Claude Code](https://claude.com/claude-code)
sudeepdino008 pushed a commit that referenced this pull request Apr 3, 2026
## Summary

Ports the full Help Center content to `release/3.4`, mirroring what was
merged to `main` via PR #20267.

Changes per file:

- **best-practices.md**: added "Harden Public RPC Endpoints" row +
Section 6 (Advanced Performance Tricks with vmtouch,
ERIGON_SNAPSHOT_MADV_RND, db.pagesize)
- **common-errors-and-solutions.md**: added errors #8 (Docker UID/GID
mismatch) and #9 (libsilkworm_capi.so missing)
- **frequently-asked-questions-faqs.md**: added FAQ #21 (historical
block queries / pruning) and #22 (ARM/RPi feasibility)
- **known-issues.md**: improved vmmap/pmap section (macOS vs Linux),
removed DOCKER_BUILDKIT env vars, added `--db.pagesize` section (default
16KB)
- **troubleshooting.md**: added Diagnostics section (SIGUSR1 goroutine
dump, pprof CPU/heap capture) and Hetzner firewall note

All content is identical to `main` post-#20267, with yperbasis review
fixes already applied (broken erigon-lib link removed, pprof addr/port
flags documented).

## Test plan

- [ ] Verify all 5 files render correctly in GitBook preview
- [ ] No broken internal links
- [ ] Content consistent with release/3.3 (PR #20263) and main

🤖 Generated with [Claude Code](https://claude.com/claude-code)
lystopad added a commit that referenced this pull request May 21, 2026
Findings from Copilot (3) and yperbasis (8). The Copilot findings on Peers
routing, empty NodeInfo, and close(statusReady) are real; yperbasis
identified the matching doc/code mismatches and a few polish items.

1. Peers() / message routing (Copilot #1). The multi-sentry client uses
   Peers() to decide which sentry owns each peer and routes SendMessageById
   via that sentry's gRPC. With the previous reporter-only gating, every
   peer mapped to Servers[0] (which is the *lowest* configured protocol,
   ETH69 in the default — yperbasis #1 noted the comment said "highest").
   Servers[0]'s goodPeers doesn't have eth/70 or eth/71 peers, so
   SendMessageById silently no-op'd.

   Fix: each GrpcServer.Peers() now reports its own goodPeers, filtered to
   skip entries where both protocol and witProtocol are zero. Each peer
   ends up in exactly one eth-sentry's goodPeers (the negotiated version)
   plus, at most, the sentry hosting the wit sideprotocol, so admin_peers
   aggregation is naturally non-duplicating and routing is correct.

2. NodeInfo() (Copilot #3). Non-reporters returning empty replies
   polluted admin_nodeInfo with blank entries that sorted first. With the
   shared p2p.Server every sentry has the same Node ID and the same enode,
   so they now return identical NodeInfo. node/eth.NodesInfo deduplicates
   by Enode before sorting.

3. SetStatus's close(ss.statusReady) (Copilot #2) panicked for callers
   that construct GrpcServer outside NewGrpcServer (existing
   TestSentryServerImpl_* does this). Guarded the close with a nil check;
   awaitStatus tolerates a nil channel via the select's other cases.

4. SetP2PServer returns an error instead of panicking on double-call
   (yperbasis #3). The "ownership decided up front" invariant is still
   enforced, just propagated up the Provider.Initialize path cleanly.

5. SimplePeerCount filters protocol=0 ghosts (yperbasis #4). With wit/0
   deduped to one sentry, peers that negotiate eth/N on a different sentry
   end up as protocol=0/witProtocol=0 ghosts on the wit-hosting sentry.
   Counting them would emit a bogus eth.ProtocolToString[0] bucket in the
   GoodPeers log. The Peers() filter already drops them from admin_peers;
   this aligns SimplePeerCount.

6. awaitStatus logs a Debug line when its timeout fires (yperbasis #5)
   so operators can tell "core didn't send status in time" from "core
   never tried" when the caller disconnects the peer with
   PeerErrorLocalStatusNeeded. Doc comment clarifies the ctx.Done case
   too (yperbasis #7).

Drops the reportsPeers flag and IsPeerReporter accessor — no longer needed
once per-sentry goodPeers replaces the reporter gating. SetP2PServer
signature loses its second argument.

Tests updated for the new shape; new TestGrpcServer_PeersReturnsPerSentryGoodPeers
(per-sentry view + ghost-entry filter) and TestGrpcServer_SetStatus_NilStatusReadyIsSafe
(close-nil guard).

Deferred to follow-up:
- BootstrapNodes/DNS resolution helper to dedupe logic between
  makeP2PServer and startSharedP2PServer (yperbasis #6).
- End-to-end Provider.Initialize test in local mode (yperbasis #8).
- [r3.4] backport PR (yperbasis #9).

Co-Authored-By: Claude
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant