fixing bugs in the function GetBlockByTimeStamp#6664
Merged
enriavil1 merged 8 commits intoJan 22, 2023
Conversation
Contributor
|
I find that here might be another problem. When getting headerByNumber through blockreader I am not able to get anything below block number 15820999. Anything lower I get nil which might be the second problem with #6408 |
Collaborator
|
FYI: @enriavil1 I think you have permissions to create branches in Erigon repo. |
Contributor
I let my brother solve it so he can start contributing to erigon. I do have permission though thank you! |
…o getBlockByTimeStamp-fix
Collaborator
|
This reverts commit cdab109.
…erAvila/erigon into getBlockByTimeStamp-fix
Contributor
|
It has changes |
enriavil1
added a commit
that referenced
this pull request
Jan 22, 2023
This reverts commit b5b9950.
AlexeyAkhunov
pushed a commit
that referenced
this pull request
Jan 22, 2023
Got rid of the lasts pr change of test data #6664
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#6408
Sometimes the number was close but too high. To solve this problem I moved backwards in order to find a closer block with the requested time stamp.