Improvements for the BSC stuck header sync#6653
Merged
Merged
Conversation
AlexeyAkhunov
added a commit
that referenced
this pull request
Jan 22, 2023
There are 3 changes: 1. Replace `anchorQueue` with `anchorTree` to be able to always walk the anchors in the order of increasing blockHeights (not possible with the queue) to prioritise making progress on the lowest block heights 2. Not increment `nextRetryTime` if the request was not sent 3. Reduce the strides in skeleton from `8*192` to `192` to reduce reliance of the long series of requests to make progress Co-authored-by: Alex Sharp <alexsharp@Alexs-MacBook-Pro-2.local>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are 3 changes:
anchorQueuewithanchorTreeto be able to always walk the anchors in the order of increasing blockHeights (not possible with the queue) to prioritise making progress on the lowest block heightsnextRetryTimeif the request was not sent8*192to192to reduce reliance of the long series of requests to make progress