claude: less verbose comments v2#21355
Merged
Merged
Conversation
sudeepdino008
approved these changes
May 22, 2026
yperbasis
added a commit
that referenced
this pull request
May 22, 2026
- Drop the BadHeaderEntry doc comment (the field names are self-descriptive and the prior wording incorrectly listed the "invalid block number" header check as an empty-string path — this PR populates it). Per #21355. - Shrink the badHeaders LRU from 10_000 to 96. Each entry now holds a heap-allocated string that won't be GC'd while cached, and the realistic working set on a healthy node is tiny. - Add unit tests pinning the ReportBadHeader/IsBadHeader round-trip for the validation-error string, including the empty-err fallback and the later-report-overrides path. - Drop the scenario-narrative comment block above the IsBadHeader short-circuit per #21355. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tried to lower comment verbosity of claude in #20870
but still not enough
this is yet another attempt to better fine tune