… tables

E3 execution stores state in kv.AccountsDomain / kv.StorageDomain /
kv.CommitmentDomain, which are incarnation-free. The following pre-E3
("E2-era") tables are dormant in production — they are not read by
the canonical execution / commitment path:

  - PlainState                  (account + storage rows; storage keys
                                 baked the per-account incarnation
                                 counter into [addr]+[inc]+[key])
  - HashedAccount / HashedStorage (legacy MPT inputs; storage keys
                                   used [hash(addr)]+[inc]+[hash(key)])
  - AccountChangeSet / StorageChangeSet (per-block reverse-diff
                                         storage with [blockNum]+[addr]
                                         (+inc) keys)
  - AccountHistory / StorageHistory (roaring-bitmap E2 history indices,
                                     superseded by the AccountHistory*
                                     / StorageHistory* domain tables)

Schema
- All seven constants move from kv.ChaindataTables to
  kv.ChaindataDeprecatedTables. The mdbx migrator opens the buckets
  read-only if they exist (DBAccede) and drops the empty ones on the
  next exclusive open; the live schema no longer recreates them on
  fresh DBs.
- DupSort flags for PlainState / HashedStorage / AccountChangeSet /
  StorageChangeSet are preserved in ChaindataTablesCfg so existing E2
  databases can still be opened with the correct bucket flags by the
  migration before it clears them.

Migration
- New drop_legacy_e2_tables migration (db/migrations/) clears all
  seven tables on existing E2-migrated databases. The migration is
  idempotent — ClearTable is a no-op on already-empty tables.

Caller cleanups
- t8ntool's CalculateStateRoot dropped the PlainState →
  HashedStorage/HashedAccounts hashing loop; ComputeCommitment reads
  from kv.CommitmentDomain directly and the loop's writes were never
  consumed.
- kvcache.AssertCheckValues (an assert-tag-only debug check that
  compared cache rows against kv.PlainState) is stubbed to a no-op —
  the active state for cache validation now lives in
  kv.AccountsDomain / kv.StorageDomain and the read-key format no
  longer matches what the cache stores.
- cmd/integration/commands/refetence_db.go and cmd/pics/state.go drop
  the deprecated tables from their debug whitelists.
- cmd/rpctest's account_range_verify used kv.E2AccountsHistory purely
  as a bucket name to JSON-dump eth_accountRange results into a fresh
  temp MDBX env for erigon/geth comparison (nothing to do with the
  actual E2 history index semantics). Switched the tool to a local
  "AccountDump" bucket via mdbx.WithTableCfg so the temp DB is fully
  decoupled from the chain schema.

Test adjustments
- TestManagedTx (db/kv/mdbx) previously picked kv.ChaindataTables[0]
  and [1] alphabetically and relied on them having matching DupSort
  flags. After the deprecated tables move, that invariant doesn't
  hold (AccountHistory (Flags=0) and AccountHistoryKeys (DupSort)
  now lead the list). Switched the test to explicit TblAccountVals /
  TblStorageVals so it does not depend on sort order.
- TestEthCallToPrunedBlock (rpc/jsonrpc) called PruneTableDupSort on
  kv.StorageChangeSetDeprecated, which the schema no longer
  materialises in ChaindataTables — cursor open panics with
  MDBX_BAD_DBI. Dropped that prune; the active prune on TblAccountVals
  exercises the same code path.

This is the schema-cleanup half of #12440 (incarnation removal) —
the in-memory IncarnationPath removal and the storage-key /
legacy-MPT encoding changes ship separately on top of this PR.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

…clear

Address Copilot review on #21280:

- drop_legacy_e2_tables migration was calling tx.ClearTable, which only
  empties the bucket (MDBX Drop with del=false) and leaves the bucket
  metadata in place. The doc comments on both the migration and the
  matching ChaindataDeprecatedTables / ChaindataTablesCfg entries said
  "drop" or "clears + drops" — overstated relative to the implementation.
  Switch to tx.DropTable: it requires IsDeprecated=true (which these
  tables now have), reclaims the bucket metadata, and is idempotent —
  dropEvenIfBucketIsNotDeprecated handles the NonExistingDBI case and
  returns nil if a re-open with mdbx.IsNotFound fails.
- eth_call_test.go's doPrune was leaking the time.NewTicker(20s) it
  created for the prune progress log; nothing called Stop() so the
  underlying ticker goroutine survived each test run. Add the missing
  defer.
- Tighten the comment in doPrune to say StorageChangeSetDeprecated is
  no longer "part of the active schema" rather than "materialised in
  the active schema".

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

…ad PlainState test puts

AssertCheckValues was the E2 sanity check that compared cache rows
against kv.PlainState. With PlainState moved to the deprecated-tables
list it could no longer do its job; the previous commit left a no-op
stub so the assert-tag-only call site in txnprovider/txpool/pool.go
would still compile. Just remove both — the stub had no callers outside
this repo and the txpool assertion never observed a real divergence in
practice.

Also drop the `tx.Put(kv.PlainState, ...)` calls in TestEviction: they
silently failed via `_ = tx.Put(...)` and TestEviction's assertions
key off c.OnNewBlock populating the cache directly, not those puts.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

The two mdbx envs opened by CompareAccountRange were never closed, so
running the debug tool repeatedly in-process would leak file
descriptors and keep MDBX locks held. Pre-existing in the function but
flagged on the touched lines by the PR review.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>