db/recsplit: set ExistenceFilterVersion to 1#21164
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
AskAlexSharov
approved these changes
May 13, 2026
sudeepdino008
added a commit
that referenced
this pull request
Jun 3, 2026
- Merge `origin/main` (up to #21546) into the `performance` branch. - Conflicts resolved by taking main's finalized form where the perf branch was behind (`ExistenceFilterVersion`→1 per #21164, `mdbx-go`→v0.40.1, `merge.go` `findMergeRangeInFiles` refactor, dropped `erigon-snapshot` module dep, fusefilter deferred-close refactor, `Versions.MustSupport`, atomic per-key prune throttle). - Adopted main's collation-at-tip design (`CollateAndPrune` in the FCU path, #21398/#21415) and removed the perf branch's older `frozenBlocks`-gating (`SetFrozenBlocksProvider`/`MaxCollatableTxNum`, `db/services/snapshot_progress.go`, its gating tests, and callers). - Verified: `make erigon integration` build, `make lint` (clean), `make test-short` (green).
1 task
pull Bot
pushed a commit
to Dustin4444/erigon
that referenced
this pull request
Jun 13, 2026
## Summary Re-enable the sharded FuseFilter existence-filter format by setting `ExistenceFilterVersion` back from `1` to `2` in `db/recsplit/recsplit.go`. This is the switch that erigontech#21164 turned off after erigontech#20644 introduced the format. New index files (`.kvi`/`.efi`) will again embed the sharded BinaryFuse filter (256 shards by `keyHash>>56`), which cuts existence-filter build-time RAM ~256× (the motivation was bloatnet 3B-key `.efi` builds). ## Why it's safe - **Read path is version-aware.** `db/recsplit/index.go` reads the embedded `dataStructureVersion` per file and dispatches to v0/v1/v2 readers, so existing v1 files stay readable and new v2 files are read by the matching `case 2` path. - **Accessor/existence files are built locally, not seeded.** `SeedableV3Extensions()` publishes only `.kv/.v/.ef/.ap`; `.kvi/.efi/.kvei` are rebuilt locally via `BuildMissedAccessors`, so this does not affect the shared snapshot set. ## Test plan - [ ] CI green Co-authored-by: JkLondon <me@ilyamikheev.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ExistenceFilterVersionfrom 2 to 1 indb/recsplit/recsplit.go. New index files will use the monolithic FuseFilter format instead of the sharded one.Test plan
🤖 Generated with Claude Code