exec: separate tickers of logging and membatch-size-check #21125
Merged
Conversation
…ial executor LogInterval (20s) was driving both progress logs and membatch size checks. Split them: logEvery (20s) for logs only, commitEvery (5s) for the batch-full check so a full membatch triggers a commit within 5s instead of up to 20s.
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request improves serial execution responsiveness by decoupling progress logging from the periodic “membatch full” check, allowing full batches to trigger a commit check more frequently without increasing log volume.
Changes:
- Added a new 5s ticker in the serial executor to check whether the state batch is full.
- Kept the existing 20s ticker dedicated to
LogExecution()only. - Ensured periodic commitment/commit checks can be triggered sooner when the batch reaches its size threshold.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
yperbasis
approved these changes
May 12, 2026
JkLondon
approved these changes
May 12, 2026
Member
|
|
sudeepdino008
pushed a commit
that referenced
this pull request
May 13, 2026
## Summary - `LogInterval` (20 s) was controlling both progress-log emission and membatch size checks in the serial executor - Split into two tickers: `logEvery` (20 s) for `LogExecution()` only, and `checkIsBatchFullEvery` (5 s) for the batch-full check - A full membatch now triggers a commit within 5 s instead of up to 20 s - The parallel executor is unaffected — it already checks batch size inline after every block result (event-driven, no ticker needed)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LogInterval(20 s) was controlling both progress-log emission and membatch size checks in the serial executorlogEvery(20 s) forLogExecution()only, andcheckIsBatchFullEvery(5 s) for the batch-full check