Skip to content

ci: add discv5 to devp2p Hive shard, bump hive pins#21065

Merged
yperbasis merged 3 commits into
mainfrom
yperbasis/bee2
May 8, 2026
Merged

ci: add discv5 to devp2p Hive shard, bump hive pins#21065
yperbasis merged 3 commits into
mainfrom
yperbasis/bee2

Conversation

@yperbasis

@yperbasis yperbasis commented May 8, 2026

Copy link
Copy Markdown
Member

Closes #17354

Summary

  • Add discv5 to the devp2p Hive matrix shard (sim-limit: eth|discv5)
  • Bump hive_ref to ethereum/hive@15750c9
  • Bump execution_apis_ref to ethereum/execution-apis@8d6b784

Test plan

🤖 Generated with Claude Code

yperbasis and others added 3 commits May 8, 2026 12:56
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…d6b784

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@yperbasis yperbasis marked this pull request as ready for review May 8, 2026 11:12
@yperbasis yperbasis enabled auto-merge May 8, 2026 11:14
@yperbasis yperbasis added this pull request to the merge queue May 8, 2026
Merged via the queue into main with commit a9a3c6d May 8, 2026
48 of 74 checks passed
@yperbasis yperbasis deleted the yperbasis/bee2 branch May 8, 2026 12:33
Sahil-4555 pushed a commit to Sahil-4555/erigon that referenced this pull request May 30, 2026
## Summary

Restores `discv5` coverage to the devp2p Hive shard, which erigontech#21017
dropped from CI.

erigontech#21065 added `discv5` to the devp2p shard (`sim-limit: eth|discv5`),
closing erigontech#17354. erigontech#21017 ("matrix-test serial vs parallel exec across the
test workflows") then added a `serial`/`parallel` exec-mode axis and, in
its `ci: align test-hive devp2p sim-limit` commit, reverted both legs to
`sim-limit: eth` — citing a comment that erigontech#21065 had itself deleted. That
removed discv5 from CI entirely.

erigontech#21017's underlying point was valid, though: `discv5` exercises peer
discovery, not the EL execution path, so running it under *both* exec
modes would be redundant. So rather than re-adding it to both legs, this
keeps `discv5` in the **parallel** leg only and documents why the serial
leg omits it:

- **serial** devp2p leg: `sim-limit: eth`
- **parallel** devp2p leg: `sim-limit: eth|discv5`

`hive-versions.json` already carries erigontech#21065's pins (`hive_ref:
15750c9…`, `execution_apis_ref: 8d6b784…`), so `discv5` runs against the
same hive revision it originally passed on.

## Test plan
- Test Hive runs automatically on this PR via **CI Gate** — the changed
workflow file counts as a code change, so the `hive` job is not skipped
— exercising `devp2p` `discv5` in the parallel exec leg.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-authored-by: Giulio Rebuffo <111551070+Giulio2002@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix all Hive tests

2 participants