ci: add discv5 to devp2p Hive shard, bump hive pins#21065
Merged
Conversation
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…d6b784 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
taratorio
approved these changes
May 8, 2026
5 tasks
Sahil-4555
pushed a commit
to Sahil-4555/erigon
that referenced
this pull request
May 30, 2026
## Summary Restores `discv5` coverage to the devp2p Hive shard, which erigontech#21017 dropped from CI. erigontech#21065 added `discv5` to the devp2p shard (`sim-limit: eth|discv5`), closing erigontech#17354. erigontech#21017 ("matrix-test serial vs parallel exec across the test workflows") then added a `serial`/`parallel` exec-mode axis and, in its `ci: align test-hive devp2p sim-limit` commit, reverted both legs to `sim-limit: eth` — citing a comment that erigontech#21065 had itself deleted. That removed discv5 from CI entirely. erigontech#21017's underlying point was valid, though: `discv5` exercises peer discovery, not the EL execution path, so running it under *both* exec modes would be redundant. So rather than re-adding it to both legs, this keeps `discv5` in the **parallel** leg only and documents why the serial leg omits it: - **serial** devp2p leg: `sim-limit: eth` - **parallel** devp2p leg: `sim-limit: eth|discv5` `hive-versions.json` already carries erigontech#21065's pins (`hive_ref: 15750c9…`, `execution_apis_ref: 8d6b784…`), so `discv5` runs against the same hive revision it originally passed on. ## Test plan - Test Hive runs automatically on this PR via **CI Gate** — the changed workflow file counts as a code change, so the `hive` job is not skipped — exercising `devp2p` `discv5` in the parallel exec leg. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Co-authored-by: Giulio Rebuffo <111551070+Giulio2002@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17354
Summary
discv5to thedevp2pHive matrix shard (sim-limit: eth|discv5)hive_reftoethereum/hive@15750c9execution_apis_reftoethereum/execution-apis@8d6b784Test plan
🤖 Generated with Claude Code