Skip to content

dbg.SaveHeapProfileNearOOMPeriodically() call in all sub-commands#20639

Merged
AskAlexSharov merged 2 commits into
release/3.4from
alex/heap_prof_save_in_subcommands_34
Apr 18, 2026
Merged

dbg.SaveHeapProfileNearOOMPeriodically() call in all sub-commands#20639
AskAlexSharov merged 2 commits into
release/3.4from
alex/heap_prof_save_in_subcommands_34

Conversation

@AskAlexSharov

Copy link
Copy Markdown
Collaborator

No description provided.

@AskAlexSharov AskAlexSharov enabled auto-merge (squash) April 18, 2026 05:22

@erigon-copilot erigon-copilot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This is the right move: starting SaveHeapProfileNearOOMPeriodically() in debug setup rather than only in node/eth/backend.go makes the near-OOM heap dumper available across subcommands, not just the full Ethereum backend path. Removing the backend-local startup also avoids double-starting it on the main node path.

@AskAlexSharov AskAlexSharov merged commit 03acd3e into release/3.4 Apr 18, 2026
21 checks passed
@AskAlexSharov AskAlexSharov deleted the alex/heap_prof_save_in_subcommands_34 branch April 18, 2026 05:33
github-merge-queue Bot pushed a commit that referenced this pull request Apr 20, 2026
Cherry-pick from `release/3.4` to `main`:

- #20635 db/state: fix MaxStep using MinTxNum in DomainRoTx.prune
- #20639 dbg.SaveHeapProfileNearOOMPeriodically() call in all
sub-commands
- #20571 blk-range: wrong logs
- #20565 merge: set merge workers to 1
- #20576 simplify user-visible logs
- #20518 cp related PRs for "don't query in db, what is in files"
- #20517 teach: Unwind beyond data in snapshots not allowed
- #20368 rpc: use synctest for TestClientCancelHTTP to fix CI flakiness
- #20329 logs: move some Info logs to Debug level
- #20262 stageloop, execmodule: add ERIGON_IN_MEM_HISTORY env flag for
in-mem history reads

---------

Co-authored-by: bendertherobert <bendertherobert@gmail.com>
Co-authored-by: moskud <sudeepdino008@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: info@weblogix.biz <admin@10gbps.weblogix.it>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant