Skip to content

ci: use App token in In-case-of-failure rollback job#20162

Merged
awskii merged 1 commit into
mainfrom
feature/lystopad/fix-in-case-of-failure-app-token
Mar 26, 2026
Merged

ci: use App token in In-case-of-failure rollback job#20162
awskii merged 1 commit into
mainfrom
feature/lystopad/fix-in-case-of-failure-app-token

Conversation

@lystopad

@lystopad lystopad commented Mar 25, 2026

Copy link
Copy Markdown
Member

Summary

  • The In-case-of-failure rollback job deletes the release git tag when the pipeline fails mid-way (after the tag was pushed but before the release completed)
  • It previously used the implicit GITHUB_TOKEN, which lacks the workflows scope — tag deletion would fail with "workflows scope may be required" if the tag pointed to a workflow-touching commit
  • Apply the same App token pattern as build-release: generate a token via RELEASE_BOT before checkout so git push -d uses the App's credentials (which carry Workflows: Write)

Test plan

  • Verify In-case-of-failure job picks up the App token on next release run
  • No change to happy-path behavior (job only runs on failure)

🤖 Generated with Claude

The rollback job deletes the release git tag when the pipeline fails
mid-way. Previously it used the implicit GITHUB_TOKEN which lacks the
`workflows` scope — so tag deletion would fail with "workflows scope
may be required" if the tag pointed to a workflow-touching commit.

Apply the same App token pattern as build-release: generate a token via
RELEASE_BOT before checkout so that git push -d uses the App's
credentials, which carry Workflows:Write permission.

Co-Authored-By: Claude
@lystopad lystopad added this pull request to the merge queue Mar 26, 2026
yperbasis pushed a commit that referenced this pull request Mar 26, 2026
…lback (#20164)

Cherry-pick of #20157 and #20162 to `release/3.3`.

## Summary

- `build-release`: use GitHub App token for checkout so `git push` of
the release tag has `workflows` scope (#20157)
- `In-case-of-failure`: same App token treatment for the rollback `git
push -d` that deletes the tag on failure (#20162)

Both fixes require `RELEASE_BOT` App to have `Workflows: Write`
permission (already granted).

Co-Authored-By: Claude
yperbasis pushed a commit that referenced this pull request Mar 26, 2026
…lback (#20165)

Cherry-pick of #20157 and #20162 to `release/3.4`.

## Summary

- `build-release`: use GitHub App token for checkout so `git push` of
the release tag has `workflows` scope (#20157)
- `In-case-of-failure`: same App token treatment for the rollback `git
push -d` that deletes the tag on failure (#20162)

Both fixes require `RELEASE_BOT` App to have `Workflows: Write`
permission (already granted).

Co-Authored-By: Claude
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Mar 26, 2026
@awskii awskii added this pull request to the merge queue Mar 26, 2026
Merged via the queue into main with commit c93a0e9 Mar 26, 2026
35 checks passed
@awskii awskii deleted the feature/lystopad/fix-in-case-of-failure-app-token branch March 26, 2026 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants