ci: fix consensus spec test failure tolerance#19854
Merged
Merged
Conversation
This reverts commit ca69ab5.
The previous approach (#19037) split the step into a download step with continue-on-error and a test step that only ran if download succeeded. This was wrong: if the download failed, the test step was skipped entirely, so mainnet tests never ran either — the job just silently passed without doing anything useful. The correct behaviour is to tolerate setup/download failures but still run mainnet tests regardless, and fail the job if mainnet tests fail. Use a bash if statement: run make tests, and if it fails emit a ::warning:: annotation and skip mainnet; if it succeeds, run mainnet normally. This way transient CDN errors produce a visible warning instead of a silent skip, and actual test regressions still fail the job. Example of incorrect behaviour: https://github.com/erigontech/erigon/actions/runs/22987591330/job/66741331639#step:5:20 Reverts: #19037
AskAlexSharov
approved these changes
Mar 16, 2026
auto-merge was automatically disabled
March 16, 2026 03:08
Merge commits are not allowed on this repository
lupin012
pushed a commit
that referenced
this pull request
Mar 17, 2026
Reverts #19037 and replaces the approach. ## What was wrong #19037 split the step into a separate download step (`continue-on-error: true`) and a test step. The download step passed as intended, but the test step ran `make tests` which had `download-spec` as a Make dependency — so it re-ran the download, which failed. Example: https://github.com/erigontech/erigon/actions/runs/22987591330/job/66741331639#step:5:20 ## Fix Revert the Makefile split (curl back inline in `tests`) and use a single bash `if` statement in the workflow: - If `make tests` fails → emit a `::warning::` annotation and skip mainnet. The step exits 0, so the job passes. - If `make tests` succeeds → run `make mainnet` normally. A failure here fails the job. Transient download failures produce a visible warning rather than a failing job, and actual test regressions still fail the job.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #19037 and replaces the approach.
What was wrong
#19037 split the step into a separate download step (
continue-on-error: true) and a test step. The download step passed as intended, but the test step ranmake testswhich haddownload-specas a Make dependency — so it re-ran the download, which failed.Example: https://github.com/erigontech/erigon/actions/runs/22987591330/job/66741331639#step:5:20
Fix
Revert the Makefile split (curl back inline in
tests) and use a single bashifstatement in the workflow:make testsfails → emit a::warning::annotation and skip mainnet. The step exits 0, so the job passes.make testssucceeds → runmake mainnetnormally. A failure here fails the job.Transient download failures produce a visible warning rather than a failing job, and actual test regressions still fail the job.