ci: fix Hive Go version patching for non-alpine base images#19851
Merged
Conversation
The sed pattern only matched `golang:X.Y.Z-alpine` but the upstream Hive Dockerfile.git uses `golang:X.Y.Z-trixie`. This caused the Go version to never be patched, breaking builds when go.mod requires a newer Go than the Hive Dockerfile's default. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
mriccobene
approved these changes
Mar 12, 2026
AskAlexSharov
pushed a commit
that referenced
this pull request
Apr 8, 2026
The cherry-pick from release/3.4 reverted the sed pattern to only match -alpine suffixes, but upstream Hive now uses -trixie. Restore the generic pattern (golang:[0-9.]*-) so all distro suffixes are handled. https://claude.ai/code/session_015vdXynCZ9mbKiDUfZx9Y1F
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
golang:X.Y.Z-alpine, but the upstream HiveDockerfile.gitusesgolang:X.Y.Z-trixiego.modfromgo 1.25.0togo 1.25.7, the Hive container still had Go 1.25.0 and the build failed withgo: ../../go.mod requires go >= 1.25.7s|golang:[0-9.]*-|golang:${go_version}-|) instead of hardcoding-alpineFixes the Hive EEST failure from #19808. Once merged, the gnark-crypto v0.20.0 upgrade can be re-landed.
Test plan
🤖 Generated with Claude Code