merge, execmoduletester: add FakeMerge engine and Prague pre-deploys …#19525
Merged
Conversation
…for tests Add FakeMerge consensus engine that wraps Merge with a fake PoW scheme, mirroring the existing FakeEthash pattern. Use it in ExecModuleTester when TerminalTotalDifficultyPassed is set, and deploy Prague system contracts (EIP-7002, EIP-7251) so FinalizeAndAssemble succeeds. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
yperbasis
approved these changes
Mar 2, 2026
Member
|
this is good, I was planning on doing exact same - thanks |
mh0lt
added a commit
that referenced
this pull request
Mar 4, 2026
The PR reinstates the BlockAssembler and the move of BAL processing to the versionedio code rather than as an auxiliary set of functions in the sync process. The main advantage of this change is that it consolidates behaviour which makes agent understanding more focussed and makes the bal code re-usable in tests. This makes the codebase more streamlined avoids breaks and confusion in test analysis. It contains fixes merged by the claude agent from #19434 and #19525, along with fixes that get to a running bal-devnet-2 node. This is ready for merging. --------- Co-authored-by: taratorio <94537774+taratorio@users.noreply.github.com> Co-authored-by: yperbasis <andrey.ashikhmin@gmail.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Andrew Ashikhmin <34320705+yperbasis@users.noreply.github.com>
sudeepdino008
pushed a commit
that referenced
this pull request
Mar 4, 2026
#19525) …for tests Add FakeMerge consensus engine that wraps Merge with a fake PoW scheme, mirroring the existing FakeEthash pattern. Use it in ExecModuleTester when TerminalTotalDifficultyPassed is set, and deploy Prague system contracts (EIP-7002, EIP-7251) so FinalizeAndAssemble succeeds. This change is intended to make sure that tests which generate chains produce blocks which a finalized according to the forks specified in the test config. This is not too big a deal for pre BAL manual testing but with agents and the need to generate bals - which track system contract touches under some circumstances - this change is more important. --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
sudeepdino008
pushed a commit
that referenced
this pull request
Mar 4, 2026
The PR reinstates the BlockAssembler and the move of BAL processing to the versionedio code rather than as an auxiliary set of functions in the sync process. The main advantage of this change is that it consolidates behaviour which makes agent understanding more focussed and makes the bal code re-usable in tests. This makes the codebase more streamlined avoids breaks and confusion in test analysis. It contains fixes merged by the claude agent from #19434 and #19525, along with fixes that get to a running bal-devnet-2 node. This is ready for merging. --------- Co-authored-by: taratorio <94537774+taratorio@users.noreply.github.com> Co-authored-by: yperbasis <andrey.ashikhmin@gmail.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Andrew Ashikhmin <34320705+yperbasis@users.noreply.github.com>
sudeepdino008
pushed a commit
that referenced
this pull request
Mar 4, 2026
#19525) …for tests Add FakeMerge consensus engine that wraps Merge with a fake PoW scheme, mirroring the existing FakeEthash pattern. Use it in ExecModuleTester when TerminalTotalDifficultyPassed is set, and deploy Prague system contracts (EIP-7002, EIP-7251) so FinalizeAndAssemble succeeds. This change is intended to make sure that tests which generate chains produce blocks which a finalized according to the forks specified in the test config. This is not too big a deal for pre BAL manual testing but with agents and the need to generate bals - which track system contract touches under some circumstances - this change is more important. --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
sudeepdino008
pushed a commit
that referenced
this pull request
Mar 4, 2026
The PR reinstates the BlockAssembler and the move of BAL processing to the versionedio code rather than as an auxiliary set of functions in the sync process. The main advantage of this change is that it consolidates behaviour which makes agent understanding more focussed and makes the bal code re-usable in tests. This makes the codebase more streamlined avoids breaks and confusion in test analysis. It contains fixes merged by the claude agent from #19434 and #19525, along with fixes that get to a running bal-devnet-2 node. This is ready for merging. --------- Co-authored-by: taratorio <94537774+taratorio@users.noreply.github.com> Co-authored-by: yperbasis <andrey.ashikhmin@gmail.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Andrew Ashikhmin <34320705+yperbasis@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…for tests
Add FakeMerge consensus engine that wraps Merge with a fake PoW scheme, mirroring the existing FakeEthash pattern. Use it in ExecModuleTester when TerminalTotalDifficultyPassed is set, and deploy Prague system contracts (EIP-7002, EIP-7251) so FinalizeAndAssemble succeeds.
This change is intended to make sure that tests which generate chains produce blocks which a finalized according to the forks specified in the test config. This is not too big a deal for pre BAL manual testing but with agents and the need to generate bals - which track system contract touches under some circumstances - this change is more important.