Skip to content

Bump max blob size#18309

Merged
shohamc1 merged 3 commits into
mainfrom
shohamc1/bump-max-blob-size
Dec 15, 2025
Merged

Bump max blob size#18309
shohamc1 merged 3 commits into
mainfrom
shohamc1/bump-max-blob-size

Conversation

@shohamc1

Copy link
Copy Markdown
Contributor

Previous limit was not enough for a 6 blob EIP-4844 transaction with commitments and proofs. The theoretical max size is ~824 KB.

@shohamc1

Copy link
Copy Markdown
Contributor Author

Possible future improvement: tie this number to some multiple of MaxBlobsPerTxn so that we don't have to keep changing this number as the number of blobs increases.

Comment thread txnprovider/txpool/pool.go Outdated

// Should be enough for a transaction with 6 blobs
blobTxnMaxSize = 800_000
blobTxnMaxSize = 900_000

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Geth use txMaxSize = 1024 * 1024
should we match them for consistency? (up to you)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't hurt to increase it, I've bumped it.

@shohamc1 shohamc1 enabled auto-merge (squash) December 15, 2025 07:02
@taratorio

taratorio commented Dec 15, 2025

Copy link
Copy Markdown
Member

@shohamc1 this PR might be a good opportunity to do one change we discussed:

if len(serializedTxn) > maxSize {
	return ErrRlpTooBig
}

wrap this error with transaction type:

return fmt.Errorf("%w: type=%d", ErrRlpTooBig , txnType)

so that we get better understanding of these errors (whether they are from blobs or from private mempools)

@taratorio

Copy link
Copy Markdown
Member

@shohamc1 this PR might be a good opportunity to do one change we discussed:

if len(serializedTxn) > maxSize {
	return ErrRlpTooBig
}

wrap this error with transaction type:

return fmt.Errorf("%w: type=%d", txnType)

so that we get better understanding of these errors (whether they are from blobs or from private mempools)

or we do this in a follow up PR? up to you

@shohamc1

Copy link
Copy Markdown
Contributor Author

@taratorio it's a small change, I've done it here

@shohamc1 shohamc1 merged commit a61a8b3 into main Dec 15, 2025
18 checks passed
@shohamc1 shohamc1 deleted the shohamc1/bump-max-blob-size branch December 15, 2025 08:14
shohamc1 added a commit that referenced this pull request Dec 16, 2025
Previous limit was not enough for a 6 blob EIP-4844 transaction with
commitments and proofs. The theoretical max size is ~824 KB.
shohamc1 added a commit that referenced this pull request Dec 16, 2025
Previous limit was not enough for a 6 blob EIP-4844 transaction with
commitments and proofs. The theoretical max size is ~824 KB.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants