Bump max blob size#18309
Conversation
|
Possible future improvement: tie this number to some multiple of |
|
|
||
| // Should be enough for a transaction with 6 blobs | ||
| blobTxnMaxSize = 800_000 | ||
| blobTxnMaxSize = 900_000 |
There was a problem hiding this comment.
Geth use txMaxSize = 1024 * 1024
should we match them for consistency? (up to you)
There was a problem hiding this comment.
There was a problem hiding this comment.
Wouldn't hurt to increase it, I've bumped it.
|
@shohamc1 this PR might be a good opportunity to do one change we discussed: wrap this error with transaction type: so that we get better understanding of these errors (whether they are from blobs or from private mempools) |
or we do this in a follow up PR? up to you |
|
@taratorio it's a small change, I've done it here |
Previous limit was not enough for a 6 blob EIP-4844 transaction with commitments and proofs. The theoretical max size is ~824 KB.
Previous limit was not enough for a 6 blob EIP-4844 transaction with commitments and proofs. The theoretical max size is ~824 KB.
Previous limit was not enough for a 6 blob EIP-4844 transaction with commitments and proofs. The theoretical max size is ~824 KB.