fix(caplin): Fixes for DataColumnSidecar#18268
Merged
Giulio2002 merged 3 commits intoDec 12, 2025
Merged
Conversation
Giulio2002
approved these changes
Dec 11, 2025
Contributor
|
It will be merged ASAP and it will be pushed into the next release (will be cut soon) |
Contributor
|
uh - the message dissapeard |
Contributor
Author
|
While this can be merged I also found that both |
Contributor
|
do it in this one |
Contributor
Author
|
@Giulio2002 see revised PR description |
Contributor
|
yes saw, that's great |
auto-merge was automatically disabled
December 12, 2025 11:43
Head branch was pushed to by a user without write access
Contributor
Author
|
@Giulio2002 I had to fix the linter can you please stamp again? |
Contributor
|
yes - just re-triggered |
taratorio
pushed a commit
that referenced
this pull request
Feb 6, 2026
Based on the spec, index should return as a string from the API [Contributoor](https://github.com/ethpandaops/contributoor) is not working for Caplin because [attestantio](https://github.com/attestantio/go-eth2-client/blob/v0.27.2/api/v1/datacolumnsidecarevent.go) assumes the index to be a string and panics because it's a integer. The [swagger](https://ethereum.github.io/beacon-APIs/#/Debug/getDebugDataColumnSidecars) also says index should be a string. Additionally, the correct API path for `data_column_sidecars` is `/eth/v1/debug/beacon/data_column_sidecars` I also added `block_root` and `slot` to the SSE events Based on my testing caplin now mirrors the behavior of lighthouse, the REST API is matching the swagger/spec, and SSE is mirroring that of lighthouse and nimbus
domiwei
pushed a commit
that referenced
this pull request
Feb 6, 2026
cherry-pick #18268 --- Based on the spec, index should return as a string from the API [Contributoor](https://github.com/ethpandaops/contributoor) is not working for Caplin because [attestantio](https://github.com/attestantio/go-eth2-client/blob/v0.27.2/api/v1/datacolumnsidecarevent.go) assumes the index to be a string and panics because it's a integer. The [swagger](https://ethereum.github.io/beacon-APIs/#/Debug/getDebugDataColumnSidecars) also says index should be a string. Additionally, the correct API path for `data_column_sidecars` is `/eth/v1/debug/beacon/data_column_sidecars` I also added `block_root` and `slot` to the SSE events Based on my testing caplin now mirrors the behavior of lighthouse, the REST API is matching the swagger/spec, and SSE is mirroring that of lighthouse and nimbus Co-authored-by: Chase Wright <mysticryuujin@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the spec, index should return as a string from the API
Contributoor is not working for Caplin because attestantio assumes the index to be a string and panics because it's a integer.
The swagger also says index should be a string.
Additionally, the correct API path for
data_column_sidecarsis/eth/v1/debug/beacon/data_column_sidecarsI also added
block_rootandslotto the SSE eventsBased on my testing caplin now mirrors the behavior of lighthouse, the REST API is matching the swagger/spec, and SSE is mirroring that of lighthouse and nimbus