fix(txpool): remove double PopWorst() in pending pool overflow#18132
Merged
Conversation
AskAlexSharov
approved these changes
Dec 4, 2025
AskAlexSharov
pushed a commit
that referenced
this pull request
Dec 4, 2025
PopWorst() called twice per loop iteration when pending pool exceeds limit. First tx leaks, second gets discarded. Copy-paste mistake from diagnostics commit 53dc6c7 - baseFee and queued were fixed to use tx variable, pending was missed.
AskAlexSharov
added a commit
that referenced
this pull request
Dec 4, 2025
pick #18132 Co-authored-by: Bilog WEB3 <155262265+Bilogweb3@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PopWorst() called twice per loop iteration when pending pool exceeds limit.
First tx leaks, second gets discarded. Copy-paste mistake from diagnostics commit 53dc6c7 - baseFee and queued were fixed to use tx variable, pending was missed.