Use MaxUint64 as return value to HistoryStartFrom() if no files present#17308
Merged
Conversation
HistoryStartFrom() if no files presentHistoryStartFrom() if no files present
AskAlexSharov
requested changes
Oct 1, 2025
sudeepdino008
approved these changes
Oct 1, 2025
sudeepdino008
requested changes
Oct 1, 2025
sudeepdino008
approved these changes
Oct 1, 2025
awskii
reviewed
Oct 1, 2025
AskAlexSharov
approved these changes
Oct 2, 2025
Member
|
The RPC tests are broken in this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently default return value of 0 leads to
PrunedErrornot being thrown when commitment history is not available wheneth_getProofis invoked. This leads to incorrect root hash error, but instead aPrunedErrorshould be thrown.A default value of +∞ is more appropriate, and fixes #16776 as well.
UPDATE: It could happen that there are no history files, but there is history in MDBX, so the function is now updated to look into MDBX for the first txnum if there are history files in snapshots.