Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an off-by-one error in the calculation of endId when clamping by eventLimit.
- Changed the boundary check from
>to>=to correctly handle cases where the range size equals the limit. - Ensured that when the difference matches the limit,
endIdis reduced by one as intended.
Comments suppressed due to low confidence (1)
polygon/bridge/service.go:393
- Add a unit test for the boundary case where
endId - startId == *eventLimitto ensure this off-by-one fix behaves as expected and prevent future regressions.
if endId > startId && endId-startId >= *eventLimit {
mh0lt
approved these changes
Jul 10, 2025
antonis19
added a commit
that referenced
this pull request
Jul 11, 2025
This will make the `TestService_ProcessNewBlocksWithOverride` test pass. Co-authored-by: antonis19 <antonis19@users.noreply.github.com>
This was referenced Jul 11, 2025
antonis19
added a commit
that referenced
this pull request
Jul 11, 2025
The test has been fixed as of #16044, so there is no need to skip it anymore. Co-authored-by: antonis19 <antonis19@users.noreply.github.com>
mh0lt
added a commit
that referenced
this pull request
Jul 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will make the
TestService_ProcessNewBlocksWithOverridetest pass.