fix eth_getProof: corner case when account have a singletone storage slot#16011
Closed
awskii wants to merge 18 commits into
Closed
fix eth_getProof: corner case when account have a singletone storage slot#16011awskii wants to merge 18 commits into
eth_getProof: corner case when account have a singletone storage slot#16011awskii wants to merge 18 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when going deeper by path in tree, depth was not adjusted to step into account address first, breaking path traversal order skipping underneath branch node first
Account and Storage trie divided by depth of 64 (address hashed and nibblized length)
Addded fix for non-dereferenced keys during hsitorical prooving: once entry not found in history it should be fetched from domain latest values, but using GetAsOf i missing information to dereference keys kept in files, so i have to do GetLatest via SharedDomain implementation which automatically dereference keys making them plain and able trie to operate over them.
Closing #15924