Skip to content

Remove scan dependency #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Alesfatalis merged 6 commits into from
Apr 16, 2025
Merged

Remove scan dependency #330

Alesfatalis merged 6 commits into from
Apr 16, 2025

Conversation

@zargarzadehm
Copy link
Contributor

@zargarzadehm zargarzadehm commented Mar 7, 2025 •
edited
Loading

  • Removed node's wallet dependency
  • Removed node's scan dependency
  • In this version, oracle operators can run their oracles behind any public node with an activated blockchain indexer

@coveralls
Copy link

coveralls commented Mar 7, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 14228141742

Details

  • 132 of 403 (32.75%) changed or added relevant lines in 21 files are covered.
  • 40 unchanged lines in 14 files lost coverage.
  • Overall coverage increased (+1.0%) to 53.807%
Changes Missing Coverage Covered Lines Changed/Added Lines %
core/src/address_util.rs 3 4 75.0%
core/src/pool_commands/refresh.rs 11 12 91.67%
core/src/actions.rs 0 2 0.0%
core/src/pool_commands/publish_datapoint.rs 24 26 92.31%
core/src/cli_commands/prepare_update.rs 14 17 82.35%
core/src/pool_commands.rs 0 4 0.0%
core/src/api.rs 0 5 0.0%
core/src/cli_commands/bootstrap.rs 26 31 83.87%
core/src/metrics.rs 0 5 0.0%
core/src/cli_commands/transfer_oracle_token.rs 7 13 53.85%
Files with Coverage Reduction New Missed Lines %
core/src/cli_commands/vote_update_pool.rs 1 56.82%
core/src/pool_commands/refresh.rs 1 96.45%
ergo-chain-sim/src/chain.rs 1 77.78%
core/src/box_kind/oracle_box.rs 2 80.37%
core/src/cli_commands/bootstrap.rs 2 86.56%
core/src/cli_commands/import_pool_update.rs 2 0.0%
core/src/cli_commands/prepare_update.rs 2 68.75%
core/src/cli_commands/transfer_oracle_token.rs 2 55.0%
core/src/node_interface/node_api.rs 2 0.0%
core/src/oracle_config.rs 2 11.32%
Totals Coverage Status
Change from base Build 8802346687: 1.0%
Covered Lines: 2000
Relevant Lines: 3717
💛 - Coveralls

cannonQ added a commit to ErgoDevs/Ergo-Bounties that referenced this pull request Mar 12, 2025
@cannonQ
Mar 12th Update
497a5cc 
One closed - input-output-hk/scrypto#105
One added - ergoplatform/oracle-core#330
cannonQ added a commit to ErgoDevs/Ergo-Bounties that referenced this pull request Mar 12, 2025
@cannonQ
Mar 12th Update
2e19217 
One closed = input-output-hk/scrypto#105

One new = ergoplatform/oracle-core#330
Alesfatalis
Alesfatalis requested changes Mar 23, 2025
View reviewed changes
Copy link
Contributor

@Alesfatalis Alesfatalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully tested with current live oracle. Apart from typo all good

@Alesfatalis Alesfatalis merged commit 4a3525c into ergoplatform:develop Apr 16, 2025
6 checks passed
@zargarzadehm zargarzadehm mentioned this pull request Apr 25, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Alesfatalis Alesfatalis Alesfatalis approved these changes

Assignees

No one assigned

Labels

Bounty - 500 GORT

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zargarzadehm @coveralls @Alesfatalis @kushti