Improve overlapping version removal#982
Merged
localheinz merged 2 commits intoergebnis:mainfrom Oct 10, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #982 +/- ##
============================================
+ Coverage 97.52% 97.68% +0.15%
- Complexity 166 170 +4
============================================
Files 30 30
Lines 728 733 +5
============================================
+ Hits 710 716 +6
+ Misses 18 17 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
3c5c1a4 to
1e1f011
Compare
1e1f011 to
a850609
Compare
localheinz
approved these changes
Oct 10, 2023
Member
|
Thank you, @fredden! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request
Follows #850
Before these changes,
^1.2 || 1.3.4would not be changed. After these changes this is replaced with^1.2.Before these changes,
^1.2.0 || ~1.2.0would be replaced with~1.2.0, which is incorrect. After these changes, both^1.2.0 || ~1.2.0and~1.2.0 || ^1.2.0are replaced with^1.2.0