Remove overlapping constraints#850
Merged
localheinz merged 1 commit intoergebnis:mainfrom Feb 25, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #850 +/- ##
============================================
+ Coverage 98.08% 98.13% +0.04%
- Complexity 139 144 +5
============================================
Files 28 28
Lines 627 643 +16
============================================
+ Hits 615 631 +16
Misses 12 12
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
5bcc327 to
b1e8674
Compare
Contributor
Author
|
@localheinz would you like me to rebase (and force-push) this to create a cleaner commit history? |
Member
|
I am sorry for force-pushing into your branch! I'll let you do what you need to do! |
Contributor
Author
|
There's no need to apologise. I'm used to lots of merge commits in a branch / pull request, then a single squash-merge to put the feature / change into the main branch. It looks like you prefer to rebase and force-push, so I'll try to remember to use that method going forward. |
Co-authored-by: Andreas Möller <am@localheinz.com>
ebd26be to
6ca24ce
Compare
Member
|
Thank you, @fredden! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is a small part of #756. This change seems less controversial than some of the other changes being suggested in #756.
^1.0 || ^1.1 || ^2.0->^1.0 || ^2.0)Related to #756